Skip to content

readline: add features yank and yank pop#41301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jan 22, 2022
Merged

readline: add features yank and yank pop #41301

nodejs-github-bot merged 1 commit into from
Jan 22, 2022

Conversation

@rayw000
Copy link
Contributor

@rayw000rayw000 commented Dec 23, 2021•
edited
Loading

  1. New features yank and yank pop
  2. Unit tests for the new features
  3. Document the new features

Fixes: #41252

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Dec 23, 2021
jasnell
jasnell reviewed Dec 23, 2021
View reviewed changes
jasnell
jasnell reviewed Dec 23, 2021
View reviewed changes
@jasnell
Copy link
Member

jasnell commented Dec 23, 2021

+1 to adding this. Needs tests and doc updates also tho

@jasnelljasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 23, 2021
@rayw000
Copy link
ContributorAuthor

rayw000 commented Dec 23, 2021

+1 to adding this. Needs tests and doc updates also tho

No problem. I'll update tomorrow.

@rayw000rayw000 changed the title repl: add feature yank and yank popreadline: add feature yank and yank popDec 24, 2021
@rayw000rayw000 requested a review from jasnellDecember 24, 2021 04:25
VoltrexKeyva
VoltrexKeyva reviewed Dec 24, 2021
View reviewed changes
@rayw000rayw000 changed the title readline: add feature yank and yank popreadline: add features yank and yank popDec 24, 2021
jasnell
jasnell reviewed Jan 17, 2022
View reviewed changes
@rayw000
Copy link
ContributorAuthor

rayw000 commented Jan 18, 2022

This PR and #41392 are conflicting. Once one of them is accepted, I'll update the other.

@rayw000rayw000 mentioned this pull request Jan 18, 2022
Merged
@Ayase-252Ayase-252 added the blocked PRs that are blocked by other issues or PRs. label Jan 21, 2022
@Ayase-252
Copy link
Member

Ayase-252 commented Jan 21, 2022

Blocked on #41392

@Ayase-252Ayase-252 removed the blocked PRs that are blocked by other issues or PRs. label Jan 21, 2022
@Ayase-252
Copy link
Member

Ayase-252 commented Jan 21, 2022

#41392 was merged. Unblocked

@rayw000
readline: add feature yank and yank pop
d7204be
1. `Ctrl-Y` to yank previously deleted text 2. `Meta-Y` to do yank pop (cycle among deleted texts) 3. Use `getCursorPos().rows` to check if we have reached a new line, instead of `getCursorPos().cols === 0`. 4. document and unittests.
@Ayase-252Ayase-252 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/42068/

@github-actionsgithub-actionsbot mentioned this pull request Jan 22, 2022
Open
17 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/42077/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/42078/

@Ayase-252Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 22, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2022
@nodejs-github-botnodejs-github-bot merged commit 2f17004 into nodejs:masterJan 22, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 22, 2022

Landed in 2f17004

@rayw000rayw000 deleted the feature-yank branch January 22, 2022 10:57
This was referenced Jan 23, 2022
Open
Open
Open
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@rayw000@BethGriggs
readline: add feature yank and yank pop
0a31149
1. `Ctrl-Y` to yank previously deleted text 2. `Meta-Y` to do yank pop (cycle among deleted texts) 3. Use `getCursorPos().rows` to check if we have reached a new line, instead of `getCursorPos().cols === 0`. 4. document and unittests. PR-URL: #41301Fixes: #41252 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Jan 26, 2022
Open
26 tasks
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@rayw000@Linkgoron
readline: add feature yank and yank pop
3441fb9
1. `Ctrl-Y` to yank previously deleted text 2. `Meta-Y` to do yank pop (cycle among deleted texts) 3. Use `getCursorPos().rows` to check if we have reached a new line, instead of `getCursorPos().cols === 0`. 4. document and unittests. PR-URL: nodejs#41301Fixes: nodejs#41252 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
@danielleadams
Copy link
Contributor

danielleadams commented Apr 11, 2022

@rayw000 do you mind backporting this to v16.x? When landing the PR, it breaks tests.

@rayw000
Copy link
ContributorAuthor

rayw000 commented Apr 11, 2022

@rayw000 do you mind backporting this to v16.x? When landing the PR, it breaks tests.

Hi @danielleadams

This PR relies on #37947, which is similar to #41392. It may not be appropriate to backport #37947 since it is a semver major change.

@danielleadams
Copy link
Contributor

danielleadams commented Apr 11, 2022•
edited
Loading

@rayw000 no problem - I'll mark as don't-land-to-v16.x. Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments

@jasnelljasnelljasnell approved these changes

@Ayase-252Ayase-252Ayase-252 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.readlineIssues and PRs related to the built-in readline module.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Only Ctrl-Y yank doesn't work in REPL

6 participants

@rayw000@jasnell@Ayase-252@nodejs-github-bot@danielleadams@VoltrexKeyva