Skip to content

doc: use Oxford comma in crypto docs#41875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Feb 6, 2022
Merged

doc: use Oxford comma in crypto docs #41875

nodejs-github-bot merged 1 commit into from
Feb 6, 2022

Conversation

@tniessen
Copy link
Member

@tniessentniessen commented Feb 6, 2022

For consistency with the rest of the documentation, and as per the style guide.

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Feb 6, 2022
@MesteeryMesteery added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 6, 2022
@github-actions
Copy link
Contributor

github-actionsbot commented Feb 6, 2022

Fast-track has been requested by @Mesteery. Please 👍 to approve.

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2022
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 6, 2022
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2022
@nodejs-github-botnodejs-github-bot merged commit e4dfe54 into nodejs:masterFeb 6, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 6, 2022

Landed in e4dfe54

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@tniessen@ruyadorno
doc: use Oxford comma in crypto docs
ffd1933
PR-URL: #41875 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen@danielleadams
doc: use Oxford comma in crypto docs
b4f2c25
PR-URL: #41875 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen@danielleadams
doc: use Oxford comma in crypto docs
eb2072f
PR-URL: #41875 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@tniessen@danielleadams
doc: use Oxford comma in crypto docs
a9ededa
PR-URL: nodejs#41875 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@tniessen@danielleadams
doc: use Oxford comma in crypto docs
fa5889f
PR-URL: nodejs#41875 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@tniessen@danielleadams
doc: use Oxford comma in crypto docs
308940d
PR-URL: #41875 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen@danielleadams
doc: use Oxford comma in crypto docs
fd28d25
PR-URL: #41875 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@aduh95aduh95aduh95 approved these changes

+1 more reviewer

@MesteeryMesteeryMesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tniessen@nodejs-github-bot@jasnell@Trott@benjamingr@aduh95@Mesteery