src: remove separate definitions for static constexpr members#41755
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is no longer necessary (and actually deprecated) since C++17.
addaleax added c++ 
Collaborator
nodejs-github-bot commented Jan 29, 2022
Review requested:
|
nodejs-github-bot added lib / src 
benjamingr approved these changes Jan 29, 2022
addaleax added request-ci 
github-actionsbot removed the request-ci This comment has been minimized.
This comment has been minimized.
VoltrexKeyva approved these changes Jan 29, 2022
Trott approved these changes Jan 29, 2022
25 tasks
Mesteery approved these changes Jan 30, 2022
cjihrig approved these changes Jan 30, 2022
RaisinTen approved these changes Jan 30, 2022
Collaborator
nodejs-github-bot commented Jan 30, 2022
This was referenced Jan 31, 2022
addaleax added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 11, 2022
Landed in b51eba4 |
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
This is no longer necessary (and actually deprecated) since C++17. PR-URL: nodejs#41755 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
This is no longer necessary (and actually deprecated) since C++17. PR-URL: nodejs#41755 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
bengl pushed a commit that referenced this pull request Feb 22, 2022
This is no longer necessary (and actually deprecated) since C++17. PR-URL: #41755 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer necessary (and actually deprecated) since C++17.