Skip to content

Conversation

@bengl
Copy link
Member

@benglbengl commented Feb 21, 2022

2022-02-22, Version 17.6.0 (Current), @BethGriggs prepared by @bengl

Notable Changes

  • [6b88595142] - doc: deprecate notice for process methods (Yash Ladha) #41587
  • [77462b6083] - stream: revert map spec compliance (Benjamin Gruenbaum) #41931
  • [b968d89fc9] - build: remove broken x32 arch support (Ben Noordhuis) #41905
  • [ba639d052b] - (SEMVER-MINOR)esm: support https remotely and http locally under flag (Bradley Farias) #36328
  • [214d17650b] - (SEMVER-MINOR)fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
  • [ec0d623bd7] - (SEMVER-MINOR)lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
  • [3243701997] - (SEMVER-MINOR)readline: bind keystroke ctrl+6 to redo (Ray) #41662
  • [5796c3a7ea] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
    • Documentation-only.

Dependency Updates

New Collaborators

Commits

npm-robotand others added 20 commits February 11, 2022 23:27
PR-URL: #41925 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]>
1. Any keystroke emits `0x1E` will do redo action. 2. Fix bug of undo/redo. 3. More detailed document. 4. Unit tests. PR-URL: #41662 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #41791 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #41633Fixes: #40958 - move test-crypto-engine so that dummy engine is only built if tests are run Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41830 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Fixes: #41857 PR-URL: #41864 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Deprecate the process multipleResolves event to detect when a promise is resolved more than once because it never really worked. Fixes: #41554 PR-URL: #41872 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Mestery <[email protected]>
PR-URL: #41892 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
The `closed` promise may reject. Document the states where it rejects based on the spec. Fixes: #41858 PR-URL: #41860 Co-Authored-By: Mattias Buelens <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
replacable -> replaceable PR-URL: #41891 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
The ellipsis in `All together` is not needed. I've had it on my list of "small things to take care of when you get a chance" for a while. The Microsoft Style Guide says to not use ellipses except in certain cases, and that reminded me to do it. The day has arrived! PR-URL: #41888 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
There are a few places in lib where `new Error()` is called and then additional properties are attached in various ways. This creates a utility function to generate the errors. PR-URL: #41879 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Fixes: #41671 PR-URL: #41914 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Fixes: #41690 PR-URL: #41883 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Co-authored-by: Jacob Smith <[email protected]> Co-authored-by: James M Snell <[email protected]> Co-authored-by: Jordan Harband <[email protected]> Co-authored-by: James Sumners <[email protected]> PR-URL: #36328 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
PR-URL: #41889 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fixes: #41878 PR-URL: #41885 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #41623 Co-authored-by: Ouyang Yadong <[email protected]> Reviewed-By: Ouyang Yadong <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
With the introduction of the promises API for setTimeout(), the requirement that it have two parameters may not be sensible anymore in tests. PR-URL: #41901 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
I added support for x32 back in 2014 but it's been in a state of disrepair ever since, not in the least because it was never a fully supported architecture in upstream V8. V8 dropped x32 support entirely in or around 2018 so the removal from Node's build system is long overdue. Refs: #40576 PR-URL: #41905 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
An interface with index 0 doesn't make sense and makes `if_indextoname()` to return `ENXIO` which crashes the process. Fixes: #41500 PR-URL: #41547 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v17.x labels Feb 21, 2022
bengl added a commit that referenced this pull request Feb 21, 2022
Notable changes: * [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) #41991 * [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) #41587 * [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 * [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) #41905 * [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 * [0de611f] - doc: add joesepi to collaborators (Joe Sepi) #41914 * [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 PR-URL: #42072

<aid="17.6.0"></a>

## 2022-02-22, Version 17.6.0 (Current), @bengl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we've done a @releaser prepared by @potential-new-releaser format, e.g.:
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2020-10-07-version-14131-current-bethgriggs-prepared-by-danielleadams

Suggested change
## 2022-02-22, Version 17.6.0 (Current), @bengl
## 2022-02-22, Version 17.6.0 (Current), @BethGriggs prepared by @bengl

@targos
Copy link
Member

The commit message should not contain the releaser's handle.

bengl added a commit that referenced this pull request Feb 21, 2022
* 326f545 - doc: deprecate notice for process methods (Yash Ladha) #41587 * abd6967 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 * b968d89 - build: remove broken x32 arch support (Ben Noordhuis) [#41905](#41905) * 88cbceb - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](#41938) * ba639d0 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) [#36328](#36328) * 1e862b3 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](#41819) * 4fbe064 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) [#41956](#41956) * 3243701 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) [#41662](#41662) * 5796c3a - process: deprecate multipleResolves (Benjamin Gruenbaum) [#41872](#41872) * Documentation-only. * \[[`811f04bd34`](811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](#42039) * \[[`605271ba8c`](605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](#41955) * \[[`0a6f0b416f`](0a6f0b416f)] - **deps**: upgrade npm to 8.5.0 (npm-robot) [#41925](#41925) * \[[`7c19c7496e`](7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](#41991) * \[[`0de611f53a`](0de611f53a)] - **doc**: add joesepi to collaborators (Joe Sepi) [#41914](#41914) PR-URL: #42072
targosand others added 3 commits February 22, 2022 11:38
This adds more globals to the set known by ESLint. PR-URL: #42043 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Also order entries by startTime when calling getEntriesByType. Fix: #42004Fix: #42024 PR-URL: #42032Fixes: #42004Fixes: #42024 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #42057 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@richardlau
Copy link
Member

Looks like these two tests are consistently crashing the debug builds 😞 : test.parallel/test-domain-error-typestest.parallel/test-worker-heap-snapshot

From the #nodejs-release Slack thread it looks like these tests were introduced by #41818. Complicating things is that after nodejs/build#2837 (comment) we're no longer running x64 debug builds on master -- instead we're running debug builds on arm64. There was some allusion to flakiness in #41818 (review) which links through to #41204 which mentions that the crash went away in a V8 update which is not likely to land on v17.x. We probably want to hold off landing #41818 on v17.x-staging for now.

bengl added a commit that referenced this pull request Feb 22, 2022
Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072
@bengl
Copy link
MemberAuthor

bengl commented Feb 22, 2022

@benglbengl mentioned this pull request Feb 22, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 22, 2022

@BethGriggs
Copy link
Member

BethGriggs commented Feb 22, 2022

*\[[`297d217efc`](https://github.com/nodejs/node/commit/297d217efc)] - **tools**: reduce list of globals in ESLint config (Rich Trott) [#41996](https://github.com/nodejs/node/pull/41996)
*\[[`916cda4afc`](https://github.com/nodejs/node/commit/916cda4afc)] - **tools**: update remark-preset-lint-node to 3.3.1 (Rich Trott) [#41999](https://github.com/nodejs/node/pull/41999)
*\[[`7a72aa776a`](https://github.com/nodejs/node/commit/7a72aa776a)] - **tools**: update ESLint to 8.9.0 (Luigi Pinca) [#41973](https://github.com/nodejs/node/pull/41973)
*\[[`0c4977cf29`](https://github.com/nodejs/node/commit/0c4977cf29)] - **tools**: update lint-md-dependencies to rollup\@2.67.2 (Node.js GitHub Bot) [#41941](https://github.com/nodejs/node/pull/41941)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked all of them, but it looks like there's a mismatch to the commit shas on the actual branch, most probably due to one of the rebases.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest push.

bengl added a commit that referenced this pull request Feb 22, 2022
Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072

### Notable Changes

*\[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*\[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)
*\[[`6b88595142`](https://github.com/nodejs/node/commit/6b88595142)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)

### Notable Changes

*\[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)
*\[[`abd6967153`](https://github.com/nodejs/node/commit/abd6967153)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*\[[`abd6967153`](https://github.com/nodejs/node/commit/abd6967153)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)
*\[[`77462b6083`](https://github.com/nodejs/node/commit/77462b6083)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)

*\[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)
*\[[`abd6967153`](https://github.com/nodejs/node/commit/abd6967153)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)
*\[[`b968d89fc9`](https://github.com/nodejs/node/commit/b968d89fc9)] - **build**: remove broken x32 arch support (Ben Noordhuis) [#41905](https://github.com/nodejs/node/pull/41905)
*\[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - **(SEMVER-MINOR)****crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*\[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - **(SEMVER-MINOR)****crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)
*\[[`60682917dd`](https://github.com/nodejs/node/commit/60682917dd)] - **(SEMVER-MINOR)****crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)

*\[[`b968d89fc9`](https://github.com/nodejs/node/commit/b968d89fc9)] - **build**: remove broken x32 arch support (Ben Noordhuis) [#41905](https://github.com/nodejs/node/pull/41905)
*\[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - **(SEMVER-MINOR)****crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)
*\[[`ba639d052b`](https://github.com/nodejs/node/commit/ba639d052b)] - **(SEMVER-MINOR)****esm**: support https remotely and http locally under flag (Bradley Farias) [#36328](https://github.com/nodejs/node/pull/36328)
*\[[`1e862b3816`](https://github.com/nodejs/node/commit/1e862b3816)] - **(SEMVER-MINOR)****fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*\[[`1e862b3816`](https://github.com/nodejs/node/commit/1e862b3816)] - **(SEMVER-MINOR)****fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)
*\[[`214d17650b`](https://github.com/nodejs/node/commit/214d17650b)] - **(SEMVER-MINOR)****fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)

*\[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - **(SEMVER-MINOR)****crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)
*\[[`ba639d052b`](https://github.com/nodejs/node/commit/ba639d052b)] - **(SEMVER-MINOR)****esm**: support https remotely and http locally under flag (Bradley Farias) [#36328](https://github.com/nodejs/node/pull/36328)
*\[[`1e862b3816`](https://github.com/nodejs/node/commit/1e862b3816)] - **(SEMVER-MINOR)****fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)
*\[[`4fbe064ce0`](https://github.com/nodejs/node/commit/4fbe064ce0)] - **(SEMVER-MINOR)****lib**: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*\[[`4fbe064ce0`](https://github.com/nodejs/node/commit/4fbe064ce0)] - **(SEMVER-MINOR)****lib**: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956)
*\[[`ec0d623bd7`](https://github.com/nodejs/node/commit/ec0d623bd7)] - **(SEMVER-MINOR)****lib**: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956)


### Dependency Updates

*\[[`811f04bd34`](https://github.com/nodejs/node/commit/811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*\[[`811f04bd34`](https://github.com/nodejs/node/commit/811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)
*\[[`d1ef43f2aa`](https://github.com/nodejs/node/commit/d1ef43f2aa)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)

### Dependency Updates

*\[[`811f04bd34`](https://github.com/nodejs/node/commit/811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)
*\[[`605271ba8c`](https://github.com/nodejs/node/commit/605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*\[[`605271ba8c`](https://github.com/nodejs/node/commit/605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955)
*\[[`09c17481f6`](https://github.com/nodejs/node/commit/09c17481f6)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955)


### New Collaborators

*\[[`7c19c7496e`](https://github.com/nodejs/node/commit/7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*\[[`7c19c7496e`](https://github.com/nodejs/node/commit/7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991)
*\[[`90d90e3868`](https://github.com/nodejs/node/commit/90d90e3868)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991)

Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072
@bengl
Copy link
MemberAuthor

@richardlau I'm pretty sure I've fixed all of those now, but my work should certainly be checked 😄 .

@BethGriggsBethGriggs merged commit 972dd0a into v17.xFeb 22, 2022
BethGriggs added a commit that referenced this pull request Feb 22, 2022
BethGriggs pushed a commit that referenced this pull request Feb 22, 2022
Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072
@aduh95aduh95 deleted the v17.6.0-proposal branch February 22, 2022 23:56
bengl added a commit to bengl/nodejs.org that referenced this pull request Feb 23, 2022
BethGriggs pushed a commit to nodejs/nodejs.org that referenced this pull request Feb 23, 2022
Trott pushed a commit that referenced this pull request Feb 23, 2022
Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@bengl@nodejs-github-bot@targos@tniessen@richardlau@BethGriggs@npm-robot@rayw000@Mesteery@mhdawson@mscdex@benjamingr@panva@eltociear@Trott@joesepi@meixg@bmeck@eladnava@bnoordhuis