Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
test: add filesystem check to test-fs-stat-date.mjs#44174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add filesystem check to test-fs-stat-date.mjs#44174
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot commented Aug 9, 2022
Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve. |
LiviaMedeiros commented Aug 9, 2022
Marking as fast-track |
nodejs-github-bot commented Aug 14, 2022
Landed in 86276d3 |
PR-URL: #44174 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #44174 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #44174 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#44174 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos commented Sep 16, 2022
@LiviaMedeiros I cherry-picked #43714 and this commit to v16.x-staging but it doesn't seem to work as expected. |
LiviaMedeiros commented Sep 18, 2022
According to #44129 (comment), this test platform uses NFS mounts. structnfstime3{uint32 seconds; uint32 nseconds};While NFSv4 (RFC 7530, Page 21) uses signed: structnfstime4{int64_t seconds; uint32_t nseconds};This is my best guess on why could this happen. Opened #44707 against |
juanarbol commented Oct 11, 2022
This is causing the CI to fail in the v16.x release branch. I will label this as dont-land-on-v16.x; feel free to remove it if needed |
main-based alternative to: #44129Skip the test if filesystem doesn't provide correct
atimeormtimevalue fromfs.stat().