Skip to content

Conversation

@LiviaMedeiros
Copy link
Member

main-based alternative to: #44129

Skip the test if filesystem doesn't provide correct atime or mtime value from fs.stat().

@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 8, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
@nodejs-github-bot

This comment was marked as outdated.

@aduh95aduh95 requested a review from richardlauAugust 8, 2022 15:01
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@LiviaMedeirosLiviaMedeiros added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 9, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.

@LiviaMedeiros
Copy link
MemberAuthor

Marking as fast-trackPRs that do not need to wait for 48 hours to land. in case if we need this in v16.17.0 before deadlines.

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Aug 14, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2022
@nodejs-github-botnodejs-github-bot merged commit 86276d3 into nodejs:mainAug 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 86276d3

danielleadams pushed a commit that referenced this pull request Aug 16, 2022
PR-URL: #44174 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
PR-URL: #44174 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadornoruyadorno mentioned this pull request Aug 23, 2022
targos pushed a commit that referenced this pull request Sep 5, 2022
PR-URL: #44174 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
PR-URL: nodejs#44174 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@targos
Copy link
Member

@LiviaMedeiros
Copy link
MemberAuthor

According to #44129 (comment), this test platform uses NFS mounts.
According to RFC 1813, Page 21, NFSv3 uses unsigned types for timestamps:

structnfstime3{uint32 seconds; uint32 nseconds};

While NFSv4 (RFC 7530, Page 21) uses signed:

structnfstime4{int64_t seconds; uint32_t nseconds};

This is my best guess on why could this happen.

Opened #44707 against main, let me know if backport PR would be more convenient.

@richardlaurichardlau mentioned this pull request Oct 7, 2022
@juanarbol
Copy link
Member

@LiviaMedeiros I cherry-picked #43714 and this commit to v16.x-staging but it doesn't seem to work as expected. See #44542 (comment)https://ci.nodejs.org/job/node-test-binary-arm-12+/15525/RUN_SUBSET=1,label=pi2-docker/testReport/junit/(root)/test/parallel_test_fs_stat_date/

This is causing the CI to fail in the v16.x release branch. I will label this as dont-land-on-v16.x; feel free to remove it if needed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@LiviaMedeiros@nodejs-github-bot@targos@juanarbol@richardlau@aduh95