[v16.x] src: split property helpers from node::Environment#44542
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Sep 6, 2022
Review requested:
|
nodejs-github-bot added c++ This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Sep 16, 2022
Collaborator
nodejs-github-bot commented Sep 20, 2022
ruyadornoforce-pushed the v16.x-staging branch from 541252d to c1c8b6dCompare
juanarbolforce-pushed the v16.x-staging branch 4 times, most recently from 02cd9a9 to 54b9635Compare
legendecasforce-pushed the backport-44056-to-16 branch from 3b9a46b to c3c83ebCompareCollaborator
nodejs-github-bot commented Oct 31, 2022
MemberAuthor
legendecas commented Oct 31, 2022
Rebased on the latest v16.x-staging. |
BethGriggsforce-pushed the v16.x-staging branch from abd7829 to 499750fCompare
PR-URL: nodejs#44056 Refs: nodejs#42528 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Feng Yu <[email protected]>
legendecasforce-pushed the backport-44056-to-16 branch from c3c83eb to ea74cbfCompare
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 23, 2022
Collaborator
nodejs-github-bot commented Nov 24, 2022
Collaborator
nodejs-github-bot commented Nov 24, 2022
Collaborator
nodejs-github-bot commented Nov 24, 2022
richardlau pushed a commit that referenced this pull request Nov 24, 2022
PR-URL: #44056 Backport-PR-URL: #44542 Refs: #42528 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Member
richardlau commented Nov 24, 2022
Landed in 54608d8. |
This was referenced Nov 25, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44056 Backport-PR-URL: nodejs/node#44542 Refs: nodejs/node#42528 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Feng Yu <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44056 Backport-PR-URL: nodejs/node#44542 Refs: nodejs/node#42528 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #44056
Refs: #42528
Reviewed-By: Ben Noordhuis [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Feng Yu [email protected]