test: remove unused variables form http tests#4422
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The http tests seem especially prone to including unused variables. This change removes them.
Trott added http 
MemberAuthor
Trott commented Dec 26, 2015
Member
jbergstroem commented Dec 26, 2015
LGTM |
Trott added a commit to Trott/io.js that referenced this pull request Dec 29, 2015
The http tests seem especially prone to including unused variables. This change removes them. PR-URL: nodejs#4422 Reviewed-By: Johan Bergström <[email protected]>
MemberAuthor
Trott commented Dec 29, 2015
Landed in abe8a34 |
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
The http tests seem especially prone to including unused variables. This change removes them. PR-URL: nodejs#4422 Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 14, 2016
The http tests seem especially prone to including unused variables. This change removes them. PR-URL: nodejs#4422 Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
The http tests seem especially prone to including unused variables. This change removes them. PR-URL: #4422 Reviewed-By: Johan Bergström <[email protected]>
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
The http tests seem especially prone to including unused variables. This change removes them. PR-URL: nodejs#4422 Reviewed-By: Johan Bergström <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The http tests seem especially prone to including unused variables.
This change removes them.