LTS: backport no-unused-vars to v4.x-staging#4688
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
MylesBorins commented Jan 14, 2016
This was referenced Jan 14, 2016
ContributorAuthor
MylesBorins commented Jan 14, 2016
There was a big combination of weird things going on getting this to backport nicely. Some commits that were part of this large change landed in LTS a week ago. Other commits landed, but with conflicts, others were not tagged for LTS and were just missed. I'd be very interested to discuss ways we can co-ordinate moving large changes like this to LTS more efficiently. As branches diverge this kind of stuff is going to get more and more difficult. |
ContributorAuthor
MylesBorins commented Jan 14, 2016
This was referenced Jan 14, 2016
Member
Trott commented Jan 14, 2016
Ci failure for In terms of how to prevent this in the future, the obvious things that leap to mind are:
If the automation idea is appealing, maybe we can open a discussion over in the nodejs/build repo? Although I imagine getting the |
Member
Trott commented Jan 14, 2016
(Also: Nice work, @thealphanerd!) |
ContributorAuthor
MylesBorins commented Jan 14, 2016
MylesBorinsforce-pushed the v4.x-staging branch from 592237f to cf7ebd3Compare
Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests. PR-URL: nodejs#4684 Reviewed-By: Myles Borins <[email protected]>
Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements. PR-URL: nodejs#4683 Reviewed-By: Myles Borins <[email protected]>
Remove unused vars in tests PR-URL: nodejs#4536 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
In addition to removing unused vars, this also fixes an instance where booleans were set presumably to check something but then never used. This now confirms that the events that were setting the booleans are fired. PR-URL: nodejs#4425 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Remove a handful of variables that are declared but never used in the tests for the net module. PR-URL: nodejs#4430 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#4426 Reviewed-By: Johan Bergström <[email protected]>
Some of the TLS tests have variables that do not get used. This removes those variables. PR-URL: nodejs#4424 Reviewed-By: Johan Bergström <[email protected]>
Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-nodejsGH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-nodejsGH-5504.js. PR-URL: nodejs#4431 Reviewed-By: Johan Bergström <[email protected]>
The http tests seem especially prone to including unused variables. This change removes them. PR-URL: nodejs#4422 Reviewed-By: Johan Bergström <[email protected]>
Remove all remaining unused variables from tests in test/parallel. PR-URL: nodejs#4511 Reviewed-By: James M Snell<[email protected]> Reviewed-By: Johan Bergström <[email protected]>
PR-URL: nodejs#4536 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
ContributorAuthor
MylesBorins commented Jan 14, 2016
CI against current head |
ContributorAuthor
MylesBorins commented Jan 14, 2016
CI Failures look unrelated. @jasnell are we good to land this? |
Member
jasnell commented Jan 14, 2016
LGTM |
ContributorAuthor
MylesBorins commented Jan 14, 2016
landed |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces: #4683 and #4684
Backport all changes to get LTS v4.x-staging passing the linter with no-unused-vars enabled. This involved backporting commits from 10 different PRs':