test: remove unused modules#4684
Closed
+185 −147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PR-URL: nodejs#4536 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#4538 Reviewed-By: Colin Ihrig <[email protected]>
Refs: nodejs#3254 PR-URL: nodejs#4540 Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#4549 Reviewed-By: Colin Ihrig <[email protected]>
Adds Myles Borins and his public key to the README PR-URL: nodejs#4578 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Adds Evan Lucas and his public key to the README for releases PR-URL: nodejs#4579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
fix description about the latest LTS release download page to make it clear PR-URL: nodejs#4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked. PR-URL: nodejs#4589Fixes: nodejs#4576 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
The server method returns `self` in order to allow chaining. PR-URL: nodejs#4590Fixes: nodejs#4571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: nodejs#4609 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>>
- Changed colors to match frontpage as close as possible. - Links are slightly more horizontally padded as compared before to accomodate for the hover effect. - Slightly reduced the scroll indication height on the TOC. - The main content is now offset using margin instead of the previous border hack. - remove empty footer that was rendering a dark bar on the bottom of each page without any content. PR-URL: nodejs#4621 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
Useful to have for reference, especially for onboarding PR-URL: nodejs#4636 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell<[email protected]>
PR-URL: nodejs#4656 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: nodejs#4657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests.
Contributor
mscdex commented Jan 14, 2016
Member
jasnell commented Jan 14, 2016
@Trott ... linting issues here too: https://ci.nodejs.org/job/node-test-commit/1737/ |
MemberAuthor
Trott commented Jan 14, 2016
@jasnell All those linting issues are in the current |
Contributor
MylesBorins commented Jan 14, 2016
bah... #4536 only partly landed cleanly and I guess I didn't back both commits out. Just noticed it was all doc fixes afterwards, hence not having run the test suite. :fail: @Trott I'm going to rebase out that commit if you want to rebase against the updated v4.staging edit: ok v4.x-staging has been rebased and is now linting cleanly without that rule turned on. @Trott do you want to roll turning on that rule and the various fixes into this PR? I'd be more than happy to do the grunt work and send you a PR for the extra commit if you like. --> https://github.com/TheAlphaNerd/node/tree/sorry-rich is your commit from this PR cherry-picked on top of the current v4.x-staging edit: I'm going through and getting this all done :S |
MylesBorinsforce-pushed the v4.x-staging branch from 2192fc8 to d4a7d97CompareMember
jasnell commented Jan 14, 2016
Thanks @thealphanerd ! |
Contributor
MylesBorins commented Jan 14, 2016
closing for #4688 |
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 14, 2016
Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests. PR-URL: nodejs#4684 Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests. PR-URL: #4684 Reviewed-By: Myles Borins <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many tests use require() to import modules that subsequently never gets
used. This removes those imports and, in a few cases, removes other
unused variables from tests.