Skip to content

Conversation

@dennisameling
Copy link
Contributor

Visual Studio 2022 17.4 introduces native ARM64 support, including host tools for MSVC. As this won't be supported on VS2019, this commit only adds the detection logic for native ARM64 tools to vs-set-2022.

Refs: nodejs/build#2540
Refs: https://devblogs.microsoft.com/visualstudio/arm64-visual-studio/

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform. labels Aug 13, 2022
@nodejs-github-bot
Copy link
Collaborator

@lpincalpinca self-requested a review August 16, 2022 18:22
Copy link
Member

@lpincalpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

Visual Studio 2022 17.4 introduces native ARM64 support, including host tools for MSVC. As this won't be supported on VS2019, this commit only adds the detection logic for native ARM64 tools to vs-set-2022. Refs: nodejs/build#2540 Refs: https://devblogs.microsoft.com/visualstudio/arm64-visual-studio/
@dennisameling
Copy link
ContributorAuthor

dennisameling commented Jan 28, 2023

Now that #46228 has been merged, this seems to be the right time to merge this PR too. Just rebased it and ran it on an arm64 device. The build finished successfully and used the native VS2022 arm64 build tools:

PS C:\repos\node> ./vcbuild.bat arm64 release Looking for Python Python found in C:\Program Files\Python311-arm64\\python.exe Python 3.11.0rc1 Looking for Visual Studio 2022 calling: "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\\Auxiliary\Build\vcvarsall.bat" arm64 ********************************************************************** ** Visual Studio 2022 Developer Command Prompt v17.4.4 ** Copyright (c) 2022 Microsoft Corporation ********************************************************************** [vcvarsall.bat] Environment initialized for: 'arm64' Found MSVS version 17.0 configure --with-ltcg --dest-cpu=arm64 Node.js configure: Found Python 3.11.0... .... node.vcxproj -> out\Release\\node.exe Junction created for Release <<===>> out\Release Creating package... Creating node-v20.0.0-win-arm64.7z Creating node-v20.0.0-win-arm64.zip Creating node_pdb.7z Creating node_pdb.zip Package created! 

@dennisameling
Copy link
ContributorAuthor

Superseded by #46420 which just got merged 👍🏼

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dennisameling@nodejs-github-bot@jasnell@lpinca@joyeecheung