Fix Visual Studio installation detection for Arm64#46420
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added build 
Blackhexforce-pushed the fix-vswhere-arm64 branch 5 times, most recently from 3aca22a to 446769cCompare
bnoordhuis commented Jan 31, 2023
@nodejs/platform-windows-arm |
Blackhexforce-pushed the fix-vswhere-arm64 branch 3 times, most recently from 970358a to d0517b9Compare
StefanStojanovic left a comment
StefanStojanovic left a comment There was a problem hiding this comment.
These changes break building on Windows x64.
| @rem also if both are x86 | ||
| if%target_arch%==x86 if%msvs_host_arch%==x86 setvcvarsall_arg=x86 | ||
| @rem unless both the host and the target are the same | ||
| if%target_arch%==%msvs_host_arch%setvcvarsall_arg=%target_arch% |
There was a problem hiding this comment.
This fails on Windows x64, since it compares "x64" to "amd64"
There was a problem hiding this comment.
OK, thank you. Let me fix that.
There was a problem hiding this comment.
Sorry for the delay, I was OOF last week. Yes, this is fixed now.
Blackhexforce-pushed the fix-vswhere-arm64 branch from d0517b9 to 0cb7257Compare
dennisameling commented Feb 6, 2023
This might supersede #44226 in which I added VS2022-specific logic for ARM64, since VS2019 is not supported on that platform. But since MS actively discourages VS2019 installation on ARM64 devices, your approach in this PR is probably better and more future-proof. |
sxa commented Feb 6, 2023
@pbo-linaro Does this look ok to you? |
pbo-linaro commented Feb 6, 2023
@StefanStojanovic will look into this. |
StefanStojanovic left a comment
StefanStojanovic left a comment There was a problem hiding this comment.
LGTM if cross-compilation passes in CI.
Blackhexforce-pushed the fix-vswhere-arm64 branch from 0cb7257 to a054cacComparesxa commented Feb 13, 2023
I didn't think we had cross-compilation in the main CI just now so I don't think that scenario will be tested, unelss I'm missing something. |
StefanStojanovic commented Feb 20, 2023
In the node-compile-windows job, there is a win-vs2019-arm64 configuration, so although we are currently not testing ARM64 in the CI, we should be able to see if the cross-compilation passes at least. |
Blackhexforce-pushed the fix-vswhere-arm64 branch from a054cac to 13d07b5Compare
Blackhex commented Feb 27, 2023
Please, let me know if there is anything specific I can do for finishing this PR on my end. |
github-actionsbot removed the request-ci 
nodejs-github-bot commented Mar 2, 2023
richardlau added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot commented Mar 2, 2023
Landed in 0abe5ec |
PR-URL: #46420 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #46420 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #46420 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
9 participants
When
vcbuild.bat arm64was run on Windows Arm64 machine, thevswhere_usability_wrapper.cmdwas detecting proper installation of Visual Studio according to presence of x64 Build Tools which fails when there is only Arm64 version of the Build Tools.