Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
[v18.x backport] test_runner: support using --inspect with --test#44813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
MoLow commented Sep 29, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44813 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
1cffc6c to 9fbebd2CompareMemberAuthor
MoLow commented Sep 29, 2022
CC @nodejs/releasers |
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44813 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44592 Backport-PR-URL: nodejs#44813 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44620 Backport-PR-URL: nodejs#44813Fixes: nodejs#44600 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
9fbebd2 to c743751Compare--inspect with --testMoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44813 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44592 Backport-PR-URL: nodejs#44813 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
PR-URL: nodejs#44620 Backport-PR-URL: nodejs#44813Fixes: nodejs#44600 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
c743751 to 37d1e5aCompare This comment was marked as outdated.
This comment was marked as outdated.
17 tasks
Collaborator
nodejs-github-bot commented Sep 30, 2022
This was referenced Oct 1, 2022
PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44813 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#44592 Backport-PR-URL: nodejs#44813 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#44620 Backport-PR-URL: nodejs#44813Fixes: nodejs#44600 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
37d1e5a to a797681Compare This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Oct 2, 2022
RafaelGSS approved these changes Oct 2, 2022
9 tasks
MemberAuthor
MoLow commented Oct 3, 2022
danielleadams approved these changes Oct 4, 2022
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
PR-URL: #44520 Backport-PR-URL: #44813 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
PR-URL: #44592 Backport-PR-URL: #44813 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
PR-URL: #44620 Backport-PR-URL: #44813Fixes: #44600 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Contributor
danielleadams commented Oct 4, 2022
Landed in 36227ed...56c9c98 |
19 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits. lib / srcIssues and PRs related to general changes in the lib or src directory. needs-ciPRs that need a full CI run. v18.xIssues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this backport PR includes
#44520
#44592
#44620
to be merged after / on top of #44815