[v18.x backport] cli: add --watch#44815
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
nodejs-github-bot added lib / src 
PR-URL: nodejs#44366 Backport-PR-URL: nodejs#44815Fixes: nodejs#40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#44551 Backport-PR-URL: nodejs#44815 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
PR-URL: nodejs#44621 Backport-PR-URL: nodejs#44815Fixes: nodejs#44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#44739 Backport-PR-URL: nodejs#44815Fixes: nodejs#44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLowforce-pushed the backport-v18-watch-mode branch from fce6dc8 to f0f5e4fCompare
MemberAuthor
MoLow commented Sep 29, 2022
CC @nodejs/releasers |
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Sep 29, 2022
17 tasks
RafaelGSS approved these changes Sep 30, 2022
This was referenced Oct 1, 2022
danielleadams approved these changes Oct 2, 2022
danielleadams pushed a commit that referenced this pull request Oct 2, 2022
PR-URL: #44366 Backport-PR-URL: #44815Fixes: #40429 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 2, 2022
PR-URL: #44551 Backport-PR-URL: #44815 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 2, 2022
PR-URL: #44621 Backport-PR-URL: #44815Fixes: #44655 Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 2, 2022
PR-URL: #44739 Backport-PR-URL: #44815Fixes: #44735 Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Contributor
danielleadams commented Oct 2, 2022
Landed in 2e7a17d...36227ed |
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR backports:
#44366
#44551
#44621
#44739
the change needed was to skip the test combining
--importwith--watchsince--importis blocked from backporting