Skip to content

Conversation

@cjihrig
Copy link
Contributor

This commit removes the experimental warning that is emitted when the test runner is used. The test runner feature is still considered experimental, but this change makes its output easier to read.

This commit removes the experimental warning that is emitted when the test runner is used. The test runner feature is still considered experimental, but this change makes its output easier to read.
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 30, 2022
@tniessen
Copy link
Member

±0 as long as it remains experimental. (If it's just in the docs, it's easy to ignore, so if we later break the test runner, it might make users who rely on it unhappy.)

@cjihrig
Copy link
ContributorAuthor

A couple notes:

  • It would definitely still be considered experimental. I also think we should try to avoid breaking changes to the test runner at this point.
  • Currently, the warning is emitted for every test file. When using the CLI runner with many files, this can get noisy if there are failures across several files. Fortunately, this only shows up for tests with failures, but...
  • There is ongoing work to add a TAP parser which would ideally surface user output to both stdout and stderr, which would make the current behavior noisy even if nothing fails.
  • There is prior art for dropping the runtime warning when it interferes with the usability of the feature. I'm thinking of util.parseArgs() specifically, but there are probably others.

@MoLowMoLow added test_runner Issues and PRs related to the test runner subsystem. dont-land-on-v14.x and removed test Issues and PRs related to the tests. labels Oct 2, 2022
@MoLowMoLow mentioned this pull request Oct 2, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@cjihrigcjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2022
@nodejs-github-botnodejs-github-bot merged commit ad8442f into nodejs:mainOct 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ad8442f

TimShilov pushed a commit to TimShilov/node that referenced this pull request Oct 3, 2022
This commit removes the experimental warning that is emitted when the test runner is used. The test runner feature is still considered experimental, but this change makes its output easier to read. PR-URL: nodejs#44844 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
panva pushed a commit to panva/node that referenced this pull request Oct 4, 2022
This commit removes the experimental warning that is emitted when the test runner is used. The test runner feature is still considered experimental, but this change makes its output easier to read. PR-URL: nodejs#44844 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
This commit removes the experimental warning that is emitted when the test runner is used. The test runner feature is still considered experimental, but this change makes its output easier to read. PR-URL: #44844 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Oct 11, 2022
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
This commit removes the experimental warning that is emitted when the test runner is used. The test runner feature is still considered experimental, but this change makes its output easier to read. PR-URL: nodejs#44844 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
This commit removes the experimental warning that is emitted when the test runner is used. The test runner feature is still considered experimental, but this change makes its output easier to read. PR-URL: nodejs#44844 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
@cjihrigcjihrig deleted the remove-warning branch December 30, 2022 21:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig@tniessen@nodejs-github-bot@jasnell@MoLow