Skip to content

meta: fix test_runner labeling#44863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 2, 2022
Merged

meta: fix test_runner labeling #44863

nodejs-github-bot merged 1 commit into from
Oct 2, 2022

Conversation

@MoLow
Copy link
Member

@MoLowMoLow commented Oct 2, 2022•
edited
Loading

there are 3 issues fixed by this PR (I tested the changes locally)

  1. doc/api/test.md was converted to testIssues and PRs related to the tests. instead of test_runnerIssues and PRs related to the test runner subsystem.
  2. lib/test.js was converted to testIssues and PRs related to the tests. instead of test_runnerIssues and PRs related to the test runner subsystem.
  3. lib/internal/test_runner/* only adds https://github.com/nodejs/node/labels/dont-land-on-v14.x but does not add test_runnerIssues and PRs related to the test runner subsystem. (caused by meta: update test_runner in label-pr-config #44615)

examples:
#44854
#44844

the third issue did not occur yet so there is no example for it

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 2, 2022
@MoLow
Copy link
MemberAuthor

MoLow commented Oct 2, 2022

CC @nodejs/test_runner

@MoLowMoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 2, 2022
@github-actions
Copy link
Contributor

github-actionsbot commented Oct 2, 2022

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-botnodejs-github-bot merged commit e5c807e into nodejs:mainOct 2, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 2, 2022

Landed in e5c807e

@MoLowMoLow deleted the fix-test-runner-labels branch October 2, 2022 11:19
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@MoLow@danielleadams
meta: label test.js and test.md with test_runner label
2efe4d9
PR-URL: #44863 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MoLow@nodejs-github-bot@jasnell@RaisinTen