crypto: add KeyObject Symbol.toStringTag#46043
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jan 1, 2023
Review requested:
|
nodejs-github-bot added crypto 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jan 1, 2023
aduh95 approved these changes Jan 1, 2023
aduh95 added the author ready 
anonrig approved these changes Jan 1, 2023
panva added commit-queue 
tniessen approved these changes Jan 1, 2023
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 3, 2023
Landed in 2d59d6b |
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
PR-URL: nodejs#46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
PR-URL: #46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS added a commit that referenced this pull request Jan 20, 2023
Notable changes: * crypto: * (SEMVER-MINOR) add CryptoKey Symbol.toStringTag (Filip Skokan) [#46042](#46042) * (SEMVER-MINOR) add KeyObject Symbol.toStringTag (Filip Skokan) [#46043](#46043) * http: * (SEMVER-MINOR) join authorization headers (Marco Ippolito) [#45982](#45982) * lib: * add webstreams to Duplex.from() (Debadree Chatterjee) [#46190](#46190) * stream: * implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) [#46205](#46205) PR-URL: TBD
Merged
RafaelGSS added a commit that referenced this pull request Jan 20, 2023
Notable changes: * crypto: * (SEMVER-MINOR) add CryptoKey Symbol.toStringTag (Filip Skokan) [#46042](#46042) * (SEMVER-MINOR) add KeyObject Symbol.toStringTag (Filip Skokan) [#46043](#46043) * http: * (SEMVER-MINOR) join authorization headers (Marco Ippolito) [#45982](#45982) * lib: * add webstreams to Duplex.from() (Debadree Chatterjee) [#46190](#46190) * stream: * implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) [#46205](#46205) PR-URL: #46286
panva added a commit to panva/node that referenced this pull request Jan 24, 2023
PR-URL: nodejs#46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
panva added a commit to panva/node that referenced this pull request Jan 24, 2023
PR-URL: nodejs#46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#46341
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 28, 2023
PR-URL: #46043 Backport-PR-URL: #46341 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
PR-URL: #46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
PR-URL: nodejs#46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
PR-URL: nodejs#46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
bartlomieju pushed a commit to denoland/deno that referenced this pull request Jul 1, 2024
As per nodejs/node#46043, this adds Symbol.toStringTag getter to KeyObject.
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
…d#24377) As per nodejs/node#46043, this adds Symbol.toStringTag getter to KeyObject.
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
…d#24377) As per nodejs/node#46043, this adds Symbol.toStringTag getter to KeyObject.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #46042 but for the Node.js own KeyObject.