[v16.x backport] WebCryptoAPI fixes#47336
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Mar 31, 2023
Review requested:
|
nodejs-github-bot added crypto panva added a commit to panva/node that referenced this pull request Mar 31, 2023
closesnodejs#45987 PR-URL: nodejs#46042Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Backport-PR-URL: nodejs#47336
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
PR-URL: nodejs#46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panvaforce-pushed the backport-crypto-symbols-to-v16.x branch from 6a2ac47 to c915898Comparepanva changed the title 
closesnodejs#45987 PR-URL: nodejs#46042Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#46043 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panvaforce-pushed the backport-crypto-symbols-to-v16.x branch from c915898 to cca5940Comparepanva added request-ci PR-URL: nodejs#45320 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#44917 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva added commit-queue-rebase panva added a commit to panva/node that referenced this pull request Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
panva changed the title PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Backport-PR-URL: nodejs#47336
Collaborator
nodejs-github-bot commented Apr 1, 2023
30 tasks
MemberAuthor
panva commented Apr 2, 2023
cc @nodejs/backporters |
Contributor
danielleadams commented Apr 2, 2023
@panva I'm preparing v16.x for 4/4 - looks like this still needs reviewers before it can be landed. |
danielleadams approved these changes Apr 2, 2023
MemberAuthor
panva commented Apr 2, 2023
@danielleadams there was 16.x minor release 4 days ago... There's another one planned for tuesday 4/4? |
28 tasks
MemberAuthor
panva commented Apr 3, 2023
cc @nodejs/crypto |
panva added author ready 
tniessen approved these changes Apr 22, 2023
WebCryptoAPI functions' arguments are now coersed and validated as per their WebIDL definitions like in other Web Crypto API implementations. This further improves interoperability with other implementations of Web Crypto API. PR-URL: nodejs#46067 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#46563 Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#47336
Refs: nodejs#47864 PR-URL: nodejs#47877 Refs: nodejs#47864 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#47336
Collaborator
nodejs-github-bot commented May 15, 2023
Collaborator
nodejs-github-bot commented May 15, 2023
This was referenced May 16, 2023
22 tasks
MemberAuthor
panva commented Jul 26, 2023
This is no longer likely to make an impact on v16.x LTS with its EOL in ~6 week |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can safely bring v16.x WebCryptoAPI spec conformance to the level of our other LTS/current releases with the backport of these PRs:
NB: WebCryptoAPI is still experimentalIssues and PRs related to experimental features. in v16.x