net: fix family autoselection timeout handling.#47860
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented May 4, 2023
Review requested:
|
nodejs-github-bot added needs-ci 
ShogunPandaforce-pushed the autoselectfamily-timeout branch from 28763f1 to 28d9306Compare
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented May 4, 2023
Collaborator
nodejs-github-bot commented May 5, 2023
tniessen reviewed May 6, 2023
Member
tniessen left a comment
tniessen left a comment There was a problem hiding this comment.
As far as I can tell from https://github.com/nodejs/reliability, tests such as test-x509-escaping started being flaky with ERR_SOCKET_CONNECTION_TIMEOUT from within internalConnectMultiple in the first half of April, shortly after #46790 was merged. Is this PR a fix for those flaky tests, too?
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
ShogunPanda commented May 6, 2023
@tniessen I haven't checked specifically, but I think so. |
Co-authored-by: Tobias Nießen <[email protected]>
jasnell approved these changes May 10, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented May 10, 2023
Collaborator
nodejs-github-bot commented May 10, 2023
24 tasks
Collaborator
nodejs-github-bot commented May 11, 2023
ShogunPanda added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented May 11, 2023
Landed in 2d24b29 |
23 tasks
targos pushed a commit that referenced this pull request May 12, 2023
PR-URL: #47860 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This was referenced May 14, 2023
Member
targos commented May 15, 2023
This seems to introduce a crash in some cases: #48000 |
Member
targos commented May 15, 2023
I'll exclude this change from v20.2.0 while it's being investigated. |
targos added the backport-blocked-v20.x ContributorAuthor
ShogunPanda commented May 15, 2023
Thanks @targos. I'll take a look soon |
This was referenced May 16, 2023
AnnaDamm added a commit to AnnaDamm/scribblehub-to-epub that referenced this pull request May 18, 2023
…n a released version yet: nodejs/node#47860
Contributor
dharesign commented May 26, 2023
See my update here. I think there might be additional fixes required (moving this block to here). |
targos removed the backport-blocked-v20.x targos pushed a commit that referenced this pull request Jun 4, 2023
PR-URL: #47860 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jun 7, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jun 21, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 7, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 13, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 17, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Jul 26, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 4, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 14, 2023
PR-URL: #47860 Backport-PR-URL: #49016 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes timeout handling of the family autoselection.
@nodejs/net @nodejs/tsc To ensure better user experience, I disabled the attempt timeout when connecting to the last IP address available, otherwise each connection attempt would be bound to the same (pretty low) timeout.
Do you think this is a reasonable approach? Also, is this considered a semver-major change? I think people are affected by this so we might want to include in 20.x anyway.
Fixes#47822.