Skip to content

Conversation

@targos
Copy link
Member

@targostargos commented Jun 4, 2023

2023-06-08, Version 20.3.0 (Current), @targos

Notable Changes

  • [bfcb3d1d9a] - deps: upgrade to libuv 1.45.0, including significant performance improvements to file system operations on Linux (Santiago Gimeno) #48078
  • [5094d1b292] - doc: add Ruy Adorno to list of TSC members (Michael Dawson) #48172
  • [2f5dbca690] - doc: mark Node.js 14 as End-of-Life (Richard Lau) #48023
  • [b1828b325e] - (SEMVER-MINOR)lib: implement AbortSignal.any() (Chemi Atlow) #47821
  • [f380953103] - module: change default resolver to not throw on unknown scheme (Gil Tayar) #47824
  • [a94f87ed99] - (SEMVER-MINOR)node-api: define version 9 (Chengzhong Wu) #48151
  • [9e2b13dfa7] - stream: deprecate asIndexedPairs (Chemi Atlow) #48102

Commits

tniessenand others added 30 commits May 30, 2023 11:36
When OpenSSL is configured with OPENSSL_NO_ENGINE, setEngine() currently throws an internal error because the C++ binding does not export the relevant function, which causes _setEngine() to be undefined within JS. Instead, match the behavior of tls/secure-context.js and throw the existing error code ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED when OpenSSL has been configured with OPENSSL_NO_ENGINE. PR-URL: #47977 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
These limitations are not specific to the file system, so they should not be listed in the "File System Permissions" section. PR-URL: #47989 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refs: #47182 PR-URL: #47998 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The error is not necessarily due to a client certificate engine. For example, the `privateKeyEngine` option might just as well cause this error and is independent of the client certificate. Also mention that this is likely due to a compile-time option of OpenSSL itself and not due to any particular engine. PR-URL: #47976 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #48023 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
According to usage(node::util::RegisterExternalReferences) of below line, namespace has to be `util`(not `utils`). PR-URL: #48003 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #47994 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]>
PR-URL: #46401 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #48036 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #48010 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #47995 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: #47981 PR-URL: #48002 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This removes replacing `_` with `-` in the flags defined. Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #48012 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #47800Fixes: #47882 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: #48016 PR-URL: #48019 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #48039 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
PR-URL: #47821Fixes: #47811 Refs: whatwg/dom#1152 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #48031 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #48034 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #47997 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
NodeBIO's memory buffer structure does not support BIO_C_FILE_SEEK and B IO_C_FILE_TELL. This prevents OpenSSL PEM_read_bio_PrivateKey from readi ng some private keys. So I switched to OpenSSL'w own protected memory bu ffers. Fixes: #47008 PR-URL: #47160 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #47919 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #47975 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #48037 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #47972Fixes: #47664 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
PR-URL: #48062 Reviewed-By: Luke Karrys <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fixesnodejs/loaders#138 PR-URL: #47824 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #48063 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #48064 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
PR-URL: #47866 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@RafaelGSSRafaelGSS removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2023
Notable changes: deps: * upgrade to libuv 1.45.0, including significant performance improvements to file system operations on Linux (Santiago Gimeno) #48078 doc: * add Ruy Adorno to list of TSC members (Michael Dawson) #48172 * mark Node.js 14 as End-of-Life (Richard Lau) #48023 lib: * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) #47821 module: * change default resolver to not throw on unknown scheme (Gil Tayar) #47824 node-api: * (SEMVER-MINOR) define version 9 (Chengzhong Wu) #48151 stream: * deprecate asIndexedPairs (Chemi Atlow) #48102 PR-URL: #48332
@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 7, 2023

@bricss
Copy link
Contributor

Would be great to pull in latest perks 👾 from main before release 😀

@@ -37,6 +38,168 @@
* [io.js](CHANGELOG_IOJS.md)
* [Archive](CHANGELOG_ARCHIVE.md)

<a id="20.3.0"></a>

## 2023-06-08, Version 20.3.0 (Current), @targos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would have been nice to add your name here @RafaelGSS since you're going to be promoting the release 😊 not a blocker though

Copy link
Member

@RafaelGSSRafaelGSSJun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. I don't want to spin up all the CI again 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@LiviaMedeiros
Copy link
Member

Any chance to include #48344? It would fix compilation error for some CPUs.

@RafaelGSS
Copy link
Member

Any chance to include #48344? It would fix compilation error for some CPUs.

I don't think so. I currently have a limited time to rebuild the proposal on top of the main again. This should be included in Node.js v20.4.0.

@RafaelGSS
Copy link
Member

@RafaelGSSRafaelGSS merged commit 57679e1 into v20.xJun 8, 2023
@RafaelGSSRafaelGSS deleted the v20.3.0-proposal branch June 8, 2023 15:59
RafaelGSS added a commit that referenced this pull request Jun 8, 2023
RafaelGSS pushed a commit that referenced this pull request Jun 8, 2023
Notable changes: deps: * upgrade to libuv 1.45.0, including significant performance improvements to file system operations on Linux (Santiago Gimeno) #48078 doc: * add Ruy Adorno to list of TSC members (Michael Dawson) #48172 * mark Node.js 14 as End-of-Life (Richard Lau) #48023 lib: * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) #47821 module: * change default resolver to not throw on unknown scheme (Gil Tayar) #47824 node-api: * (SEMVER-MINOR) define version 9 (Chengzhong Wu) #48151 stream: * deprecate asIndexedPairs (Chemi Atlow) #48102 PR-URL: #48332
RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Jun 8, 2023
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Jun 8, 2023
@cristianArdila-h
Copy link

cristianArdila-h commented Jul 25, 2023

Hello, I try to generate a coverage report in a test suite, but when I include a test that simulates an api consumption with fetch, the report is not generated.

comand: node --experimental-test-coverage --test-reporter=tap --test-reporter-destination=file.txt --test --loader ts-node/esm test/**/*.test.ts

I generate the api mock in this way:

image

image

I have tried several options without successful results, I don't know if it is a reported bug or the problem is in my project.

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Notable changes: deps: * upgrade to libuv 1.45.0, including significant performance improvements to file system operations on Linux (Santiago Gimeno) nodejs#48078 doc: * add Ruy Adorno to list of TSC members (Michael Dawson) nodejs#48172 * mark Node.js 14 as End-of-Life (Richard Lau) nodejs#48023 lib: * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) nodejs#47821 module: * change default resolver to not throw on unknown scheme (Gil Tayar) nodejs#47824 node-api: * (SEMVER-MINOR) define version 9 (Chengzhong Wu) nodejs#48151 stream: * deprecate asIndexedPairs (Chemi Atlow) nodejs#48102 PR-URL: nodejs#48332
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Notable changes: deps: * upgrade to libuv 1.45.0, including significant performance improvements to file system operations on Linux (Santiago Gimeno) nodejs#48078 doc: * add Ruy Adorno to list of TSC members (Michael Dawson) nodejs#48172 * mark Node.js 14 as End-of-Life (Richard Lau) nodejs#48023 lib: * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) nodejs#47821 module: * change default resolver to not throw on unknown scheme (Gil Tayar) nodejs#47824 node-api: * (SEMVER-MINOR) define version 9 (Chengzhong Wu) nodejs#48151 stream: * deprecate asIndexedPairs (Chemi Atlow) nodejs#48102 PR-URL: nodejs#48332
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releaseIssues and PRs related to Node.js releases.v20.xIssues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@targos@nodejs-github-bot@RafaelGSS@ronag@MoLow@anonrig@santigimeno@tniessen@ShogunPanda@bricss@LiviaMedeiros@cristianArdila-h@ruyadorno@richardlau@shrujalshah28@deokjinkim@shipujin@daeyeon@benjamingr@Basa198