Skip to content

doc: improve the documentation of the stdio option#48110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
May 30, 2023
Merged

doc: improve the documentation of the stdio option #48110

nodejs-github-bot merged 1 commit into from
May 30, 2023

Conversation

@Karnav123
Copy link
Contributor

@Karnav123Karnav123 commented May 22, 2023•
edited
Loading

doc: Add the links to better explain stdio property of cluster.settings in the file doc/api/cluster.md#clustersettings.

Fixes: issue #47705
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings

  • doc

@nodejs-github-botnodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels May 22, 2023
lpinca
lpinca reviewed May 25, 2023
View reviewed changes
@Karnav123Karnav123 requested a review from lpincaMay 25, 2023 19:47
lpinca
lpinca reviewed May 25, 2023
View reviewed changes
@Karnav123Karnav123 changed the title Update cluster.mddoc: Update cluster.mdMay 26, 2023
@Karnav123
Copy link
ContributorAuthor

Karnav123 commented May 28, 2023

@lpinca I am sorry for bothering but this PR is not getting included in the CI run. I am not able to understand why?

@lpinca
Copy link
Member

lpinca commented May 28, 2023•
edited
Loading

It is a doc only change so there is no need for a full CI run. Can you please use a more descriptive commit title? Something like doc: improve the documentation of the stdio option should be ok.

@Karnav123Karnav123 changed the title doc: Update cluster.mddoc: improve the documentation of the stdioMay 28, 2023
@Karnav123Karnav123 changed the title doc: improve the documentation of the stdiodoc: improve the documentation of the stdio optionMay 28, 2023
@Karnav123
Copy link
ContributorAuthor

Karnav123 commented May 28, 2023

It is a doc only change so there is no need for a full CI run. Can you please use a more descriptive commit title? Something like doc: improve the documentation of the stdio option should be ok.

Thank you! Done.

@lpinca
Copy link
Member

lpinca commented May 28, 2023

@Karnav123 you changed the PR title not the first commit title. Do you want to try to do it? You need to do a git rebase. If you prefer, we can also do it before landing.

@Karnav123
Copy link
ContributorAuthor

Karnav123 commented May 29, 2023

@Karnav123 you changed the PR title not the first commit title. Do you want to try to do it? You need to do a git rebase. If you prefer, we can also do it before landing.

Please rebase and change it.

@lpincalpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2023
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2023
@nodejs-github-botnodejs-github-bot merged commit 84716d8 into nodejs:mainMay 30, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 30, 2023

Landed in 84716d8

targos pushed a commit that referenced this pull request May 30, 2023
@Karnav123@targos
doc: improve the documentation of the stdio option
8c53386
Fixes: #47705 PR-URL: #48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@Karnav123@danielleadams
doc: improve the documentation of the stdio option
0eaefd5
Fixes: #47705 PR-URL: #48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@Karnav123@MoLow
doc: improve the documentation of the stdio option
f2bb191
Fixes: nodejs#47705 PR-URL: nodejs#48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Karnav123@Ceres6
doc: improve the documentation of the stdio option
e908fef
Fixes: nodejs#47705 PR-URL: nodejs#48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Karnav123@Ceres6
doc: improve the documentation of the stdio option
23f77b7
Fixes: nodejs#47705 PR-URL: nodejs#48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.clusterIssues and PRs related to the cluster subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Karnav123@lpinca@nodejs-github-bot@jasnell