tools: alphabetize CODEOWNERS#48124
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented May 22, 2023
Review requested:
|
nodejs-github-bot added the meta 
RaisinTen approved these changes May 23, 2023
gireeshpunathil approved these changes May 23, 2023
MoLow approved these changes May 23, 2023
Mesteery approved these changes May 23, 2023
marco-ippolito approved these changes May 23, 2023
RafaelGSS approved these changes May 23, 2023
debadree25 added author ready 
lpinca approved these changes May 24, 2023
nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented May 24, 2023
Commit Queue failed- Loading data for nodejs/node/pull/48124 ✔ Done loading data for nodejs/node/pull/48124 ----------------------------------- PR info ------------------------------------ Title tools: alphabetize CODEOWNERS (#48124) Author Rich Trott (@Trott) Branch Trott:alphabetize-codeowners -> nodejs:main Labels meta, author ready Commits 1 - tools: alphabetize CODEOWNERS Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/48124 Reviewed-By: Darshan Sen Reviewed-By: Gireesh Punathil Reviewed-By: Moshe Atlow Reviewed-By: Mestery Reviewed-By: Marco Ippolito Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48124 Reviewed-By: Darshan Sen Reviewed-By: Gireesh Punathil Reviewed-By: Moshe Atlow Reviewed-By: Mestery Reviewed-By: Marco Ippolito Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 22 May 2023 22:28:02 GMT ✔ Approvals: 7 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438517385 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438534809 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438575044 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438716308 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438844200 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1439978640 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48124#pullrequestreview-1442604646 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48124 From https://github.com/nodejs/node * branch refs/pull/48124/merge -> FETCH_HEAD ✔ Fetched commits as ceb2a21edd7b..60d2b0b69501 -------------------------------------------------------------------------------- Auto-merging .github/CODEOWNERS CONFLICT (content): Merge conflict in .github/CODEOWNERS error: could not apply 60d2b0b695... tools: alphabetize CODEOWNERS hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/5074032340 |
Trottforce-pushed the alphabetize-codeowners branch from 60d2b0b to a07d3b6CompareTrott removed the commit-queue-failed 
Keep each list in CODEOWNERS in alphabetical order so it is easier to find things in the longer lists. PR-URL: nodejs#48124 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trottforce-pushed the alphabetize-codeowners branch from a07d3b6 to bd829f2Compare
MemberAuthor
Trott commented May 24, 2023
Landed in bd829f2 |
targos pushed a commit that referenced this pull request May 30, 2023
Keep each list in CODEOWNERS in alphabetical order so it is easier to find things in the longer lists. PR-URL: #48124 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Keep each list in CODEOWNERS in alphabetical order so it is easier to find things in the longer lists. PR-URL: #48124 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Keep each list in CODEOWNERS in alphabetical order so it is easier to find things in the longer lists. PR-URL: nodejs#48124 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Keep each list in CODEOWNERS in alphabetical order so it is easier to find things in the longer lists. PR-URL: nodejs#48124 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Keep each list in CODEOWNERS in alphabetical order so it is easier to find things in the longer lists. PR-URL: nodejs#48124 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep each list in CODEOWNERS in alphabetical order so it is easier to find things in the longer lists.