esm: handle globalPreload hook returning a nullish value#48249
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented May 30, 2023
Review requested:
|
nodejs-github-bot added esm 
GeoffreyBooth approved these changes May 30, 2023
Collaborator
nodejs-github-bot commented May 30, 2023
JakobJingleheimer approved these changes May 30, 2023
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented May 30, 2023
22 tasks
Collaborator
nodejs-github-bot commented May 31, 2023
jlenon7 approved these changes May 31, 2023
aduh95 added author ready nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Jun 1, 2023
Commit Queue failed- Loading data for nodejs/node/pull/48249 ✔ Done loading data for nodejs/node/pull/48249 ----------------------------------- PR info ------------------------------------ Title esm: handle `globalPreload` hook returning a nullish value (#48249) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:globalPreload-nullish -> nodejs:main Labels esm, author ready, needs-ci Commits 1 - esm: handle `globalPreload` hook returning a nullish value Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/48249 Fixes: https://github.com/nodejs/node/issues/48240 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48249 Fixes: https://github.com/nodejs/node/issues/48240 Reviewed-By: Geoffrey Booth Reviewed-By: Jacob Smith -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 30 May 2023 09:59:28 GMT ✔ Approvals: 2 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/48249#pullrequestreview-1451284058 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/48249#pullrequestreview-1451367545 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-05-31T11:02:18Z: https://ci.nodejs.org/job/node-test-pull-request/52016/ - Querying data for job/node-test-pull-request/52016/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48249 From https://github.com/nodejs/node * branch refs/pull/48249/merge -> FETCH_HEAD ✔ Fetched commits as d57dd708e249..4910e199ae84 -------------------------------------------------------------------------------- Auto-merging lib/internal/modules/esm/hooks.js Auto-merging test/es-module/test-esm-loader-hooks.mjs CONFLICT (content): Merge conflict in test/es-module/test-esm-loader-hooks.mjs error: could not apply 4910e199ae... esm: handle `globalPreload` hook returning a nullish value hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/5142967649 |
PR-URL: nodejs#48249Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
aduh95force-pushed the globalPreload-nullish branch from 4910e19 to fa1c732CompareContributorAuthor
aduh95 commented Jun 1, 2023
Landed in fa1c732 |
This was referenced Jun 2, 2023
targos pushed a commit that referenced this pull request Jun 4, 2023
PR-URL: #48249Fixes: #48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
30 tasks
franciszek-koltuniuk-red pushed a commit to franciszek-koltuniuk-red/node that referenced this pull request Jun 7, 2023
PR-URL: nodejs#48249Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Contributor
danielleadams commented Jul 6, 2023
Blocked by #45869 |
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48249Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48249Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
PR-URL: nodejs#48249Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #48249 Backport-PR-URL: #50669Fixes: #48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#48249 Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#48249 Backport-PR-URL: nodejs/node#50669Fixes: nodejs/node#48240 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #48240