Skip to content

Conversation

@tniessen
Copy link
Member

Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384.

Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384.
@tniessentniessen added the tls Issues and PRs related to the tls subsystem. label May 22, 2023
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 22, 2023
@tniessentniessen added the openssl Issues and PRs related to the OpenSSL dependency. label May 22, 2023
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus! It gets rid of a use of "currently" which is a pet peeve of mine!

@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 22, 2023
@tniessentniessen added the review wanted PRs that need reviews. label May 24, 2023
@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2023
@nodejs-github-botnodejs-github-bot merged commit 817c579 into nodejs:mainMay 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 817c579

targos pushed a commit that referenced this pull request May 30, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: #48123 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Jun 4, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: #48123 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: nodejs#48123 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: nodejs#48123 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Recent OpenSSL versions support PSKs with non-SHA-256 TLSv1.3 ciphers, e.g., TLS_AES_256_GCM_SHA384. PR-URL: nodejs#48123 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.opensslIssues and PRs related to the OpenSSL dependency.review wantedPRs that need reviews.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@nodejs-github-bot@Trott@lpinca@aymen94@panva