Skip to content

Conversation

@atlowChemi
Copy link
Member

@atlowChemiatlowChemi commented May 21, 2023

I recently started contributing to the node project. I am looking forward to getting more involved in the node project, and one day becoming a collaborator 🙏🏽
I have read node's code of conduct, and I will adhere to it

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 21, 2023
@benjamingr
Copy link
Member

@gireeshpunathil

Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entry needs to be moved, but other than that, this looks good to me.

@atlowChemiatlowChemi requested a review from TrottMay 21, 2023 16:31
@MoLow
Copy link
Member

👍🏻 I'l let others approve this as we are brothers ❤️

Copy link
Member

@RaisinTenRaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
cc @nodejs/issue-triage

Copy link
Member

@daeyeondaeyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard!

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48104 ✔ Done loading data for nodejs/node/pull/48104 ----------------------------------- PR info ------------------------------------ Title doc: add atlowChemi to triagers (#48104) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch atlowChemi:add-atlowChemi-to-triagers -> nodejs:main Labels doc Commits 2 - doc: add atlowChemi to triagers - re-order Committers 1 - atlowChemi PR-URL: https://github.com/nodejs/node/pull/48104 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Qingyu Deng Reviewed-By: Darshan Sen Reviewed-By: Daeyeon Jeong Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Feng Yu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48104 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Qingyu Deng Reviewed-By: Darshan Sen Reviewed-By: Daeyeon Jeong Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Feng Yu -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 21 May 2023 16:08:49 GMT ✔ Approvals: 8 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435563635 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435564304 ✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435713363 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435794234 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435797533 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/48104#pullrequestreview-1436005936 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48104#pullrequestreview-1444503120 ✔ - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/48104#pullrequestreview-1444841370 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48104 From https://github.com/nodejs/node * branch refs/pull/48104/merge -> FETCH_HEAD ✔ Fetched commits as 186307a48432..313f80f3a60e -------------------------------------------------------------------------------- Auto-merging README.md [main 9117246235] doc: add atlowChemi to triagers Author: atlowChemi Date: Sun May 21 19:00:00 2023 +0300 1 file changed, 2 insertions(+) Auto-merging README.md [main 86e4513914] re-order Author: atlowChemi Date: Sun May 21 19:31:26 2023 +0300 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) 

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: add atlowChemi to triagers

PR-URL: #48104
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Qingyu Deng [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Daeyeon Jeong [email protected]
Reviewed-By: Mohammed Keyvanzadeh [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Feng Yu [email protected]

[detached HEAD 2449a12bb8] doc: add atlowChemi to triagers
Author: atlowChemi [email protected]
Date: Sun May 21 19:00:00 2023 +0300
1 file changed, 2 insertions(+)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
re-order

PR-URL: #48104
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Qingyu Deng [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Daeyeon Jeong [email protected]
Reviewed-By: Mohammed Keyvanzadeh [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Feng Yu [email protected]

[detached HEAD 58f7772041] re-order
Author: atlowChemi [email protected]
Date: Sun May 21 19:31:26 2023 +0300
1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5103062163

@MoLowMoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 28, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2023
@nodejs-github-botnodejs-github-bot merged commit 7f6f17e into nodejs:mainMay 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 7f6f17e

@atlowChemiatlowChemi deleted the add-atlowChemi-to-triagers branch May 28, 2023 08:30
targos pushed a commit that referenced this pull request May 30, 2023
PR-URL: #48104 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Feng Yu <[email protected]>
@targostargos mentioned this pull request Jun 4, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #48104 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Feng Yu <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#48104 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48104 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48104 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@atlowChemi@benjamingr@MoLow@nodejs-github-bot@Trott@lpinca@Ayase-252@daeyeon@F3n67u@RaisinTen@VoltrexKeyva