net: fix family autoselection SSL connection handling#48189
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented May 26, 2023
mscdex reviewed May 26, 2023
| const{request } = require('https'); | ||
| request( | ||
| 'https://nodejs.org/en', |
Contributor
There was a problem hiding this comment.
Shouldn't this test go in test/internet/ if it's attempting to reach an internet host?
ContributorAuthor
There was a problem hiding this comment.
Yes, I didn't know about it. Fixed now.
| const{request } = require('https'); | ||
| request( | ||
| 'https://nodejs.org/en', |
Member
There was a problem hiding this comment.
If this is reaching out to the internet this should go in internet and not parallel. It should also be using a constant from common/internet to allow people to run the test suites in places that restrict access to some addresses.
ContributorAuthor
There was a problem hiding this comment.
Thanks, I didn't know about this. This is fixed now.
This was referenced May 27, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented May 28, 2023
Collaborator
nodejs-github-bot commented May 28, 2023
Collaborator
nodejs-github-bot commented May 28, 2023
Collaborator
nodejs-github-bot commented May 28, 2023
22 tasks
ShogunPandaforce-pushed the fix-family-autoselection-ssl-connect branch from 7425b2d to 5150216Comparegithub-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented May 29, 2023
jasnell approved these changes May 29, 2023
23 tasks
ContributorAuthor
ShogunPanda commented May 30, 2023
@nodejs/build I have a failure in GH suite but I don't think it's related to my changes. Can I ignore or do you first want to address it? |
marco-ippolito approved these changes May 30, 2023
22 tasks
This was referenced May 31, 2023
ContributorAuthor
ShogunPanda commented May 31, 2023
Landed in 26450c5 |
ShogunPanda added a commit that referenced this pull request May 31, 2023
PR-URL: #48189 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Member
targos commented May 31, 2023
The test-internet failure was confirmed to be unrelated and we opened #48262 for it. |
This was referenced Jun 2, 2023
targos pushed a commit that referenced this pull request Jun 4, 2023
PR-URL: #48189 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
franciszek-koltuniuk-red pushed a commit to franciszek-koltuniuk-red/node that referenced this pull request Jun 7, 2023
PR-URL: nodejs#48189 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48189 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48189 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 15, 2023
PR-URL: nodejs#48189 Backport-URL: Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 15, 2023
PR-URL: nodejs#48189 Backport-PR-URL: Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 15, 2023
PR-URL: nodejs#48189 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 17, 2023
PR-URL: #48189 Backport-PR-URL: #49183 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes SSL connection attempts by not attempting to restore SSL information (like server name) if such informations are not available anymore.
Fixes#48000.