url: clean vertical alignment of docs#48037
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented May 16, 2023
Review requested:
|
nodejs-github-bot added needs-ci 
anonrig approved these changes May 16, 2023
Contributor
deokjinkim commented May 17, 2023
@binury Thank you for your PR! Commit title should start with subsystem such as https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines |
panva changed the title 
deokjinkim added request-ci 
deokjinkim approved these changes May 18, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented May 18, 2023
deokjinkim added the commit-queue 
panva approved these changes May 18, 2023
lpinca approved these changes May 18, 2023
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented May 18, 2023
Landed in 67b892e |
fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
PR-URL: nodejs#48037 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2023
PR-URL: #48037 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #48037 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#48037 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forward slash of the comment on line 656 came loose.
This PR restores the structural integrity of the vertically-aligned column and improves resilience to undesired wavering.
Our OCD thanks you for your consideration of this tiny PR