node-api: add status napi_cannot_run_js#47986
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
Review requested:
|
nodejs-github-bot added c++ 
gabrielschulhofforce-pushed the cannot-call-into-js-status branch from b2fd523 to a843857Compare
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code.
gabrielschulhofforce-pushed the cannot-call-into-js-status branch from a843857 to 0e89301Compare
tniessen changed the title 
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
gabrielschulhof commented May 18, 2023
@legendecas I have addressed your review comments. Please take another look! |
legendecas approved these changes May 19, 2023
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
nodejs-github-bot commented May 19, 2023
Some platforms do not seem to support target_defaults.
Collaborator
nodejs-github-bot commented May 19, 2023
Collaborator
nodejs-github-bot commented May 19, 2023
19 tasks
Collaborator
nodejs-github-bot commented May 20, 2023
gabrielschulhof added a commit that referenced this pull request May 20, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: #47986 Reviewed-By: Chengzhong Wu <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]>
16 tasks
fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: nodejs#47986 Reviewed-By: Chengzhong Wu <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]>
fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: nodejs#47986 Reviewed-By: Chengzhong Wu <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]>
This was referenced May 23, 2023
21 tasks
kvakil added a commit to kvakil/node that referenced this pull request May 25, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the nodejs#1 failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576
kvakil added a commit to kvakil/node that referenced this pull request May 25, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576
This was referenced May 26, 2023
nodejs-github-bot pushed a commit that referenced this pull request May 27, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: #48180 Refs: #47986 Refs: nodejs/reliability#576 PR-URL: #48181 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
20 tasks
targos pushed a commit that referenced this pull request May 30, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: #47986 Reviewed-By: Chengzhong Wu <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: #48180 Refs: #47986 Refs: nodejs/reliability#576 PR-URL: #48181 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This was referenced Jun 21, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: #47986 Reviewed-By: Chengzhong Wu <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: #48180 Refs: #47986 Refs: nodejs/reliability#576 PR-URL: #48181 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: nodejs#47986 Reviewed-By: Chengzhong Wu <[email protected]> Signed-off-by: Gabriel Schulhof <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576 PR-URL: nodejs#48181 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576 PR-URL: nodejs#48181 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576 PR-URL: nodejs#48181 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code.