Revert "tools: open issue when update workflow fails"#48312
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit c488558.
Collaborator
nodejs-github-bot commented Jun 3, 2023
Review requested:
|
nodejs-github-bot added the meta 
richardlau approved these changes Jun 3, 2023
Mesteery approved these changes Jun 3, 2023
marco-ippolito added fast-track 
Contributor
Fast-track has been requested by @marco-ippolito. Please 👍 to approve. |
Member
tniessen commented Jun 3, 2023
Why did the step run at all? #48308 was opened by a manual run, wasn't it? |
MemberAuthor
marco-ippolito commented Jun 3, 2023
aduh95 approved these changes Jun 3, 2023
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 3, 2023
Landed in fdf8ecd |
targos pushed a commit that referenced this pull request Jun 4, 2023
This reverts commit c488558. PR-URL: #48312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
This reverts commit c488558. PR-URL: #48312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
This reverts commit c488558. PR-URL: nodejs#48312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
This reverts commit c488558. PR-URL: nodejs#48312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
This reverts commit c488558. PR-URL: nodejs#48312 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c488558.
the action creates an issue that dep update failed: #48309 but actually worked #48308, while other jobs failed