Skip to content

Conversation

@MoLow
Copy link
Member

@MoLowMoLow commented Jun 1, 2023

Fixes: #47937

@MoLowMoLow requested review from benjamingr and cjihrigJune 1, 2023 10:06
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 1, 2023
@MoLow
Copy link
MemberAuthor

MoLow commented Jun 3, 2023

ping @nodejs/test_runner can someone take a look?

@MoLowMoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 4, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 4, 2023
@nodejs-github-bot
Copy link
Collaborator

MoLow added a commit that referenced this pull request Jun 4, 2023
PR-URL: #48279Fixes: #47937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow
Copy link
MemberAuthor

MoLow commented Jun 4, 2023

Landed in 5c27cc2

@MoLowMoLow closed this Jun 4, 2023
@MoLowMoLow deleted the fix-suite-children-only branch June 4, 2023 21:06
targos pushed a commit that referenced this pull request Jun 5, 2023
PR-URL: #48279Fixes: #47937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targostargos mentioned this pull request Jun 5, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #48279Fixes: #47937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#48279Fixes: nodejs#47937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48279Fixes: nodejs#47937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48279Fixes: nodejs#47937 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

it.only inside describe.only run all other its as well

6 participants

@MoLow@nodejs-github-bot@ljharb@benjamingr@cjihrig@aduh95