Skip to content

tools: don't gitignore base64 config.h#48174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
May 30, 2023
Merged

tools: don't gitignore base64 config.h #48174

nodejs-github-bot merged 1 commit into from
May 30, 2023

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuisbnoordhuis commented May 25, 2023

The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds:

  1. Download and unpack tarball
  2. Check the sources into git with git init; git add .; git commit -a
  3. Clean the source tree with git clean -dfx
  4. Run ./configure && make
  5. Observe build failure because config.h is missing

Fixes: #47638

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels May 25, 2023
@bnoordhuisbnoordhuis mentioned this pull request May 25, 2023
Closed
targos
targos reviewed May 25, 2023
View reviewed changes
@bnoordhuisbnoordhuis changed the title deps: don't gitignore base64 config.htools: don't gitignore base64 config.hMay 25, 2023
targos
targos reviewed May 25, 2023
View reviewed changes
lpinca
lpinca reviewed May 25, 2023
View reviewed changes
@bnoordhuis
tools: don't gitignore base64 config.h
cb448d5
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: nodejs#47638
@bnoordhuisbnoordhuis added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels May 27, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 27, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51978/

This was referenced May 28, 2023
Open
Open
@bnoordhuisbnoordhuis added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52000/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52002/

@github-actionsgithub-actionsbot mentioned this pull request May 30, 2023
Open
23 tasks
@bnoordhuisbnoordhuis added the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2023
@nodejs-github-botnodejs-github-bot merged commit fe76e09 into nodejs:mainMay 30, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 30, 2023

Landed in fe76e09

This was referenced May 31, 2023
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Jun 4, 2023
@bnoordhuis@targos
tools: don't gitignore base64 config.h
5f08bfe
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: #47638 PR-URL: #48174 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@targostargos mentioned this pull request Jun 4, 2023
Merged
@github-actionsgithub-actionsbot mentioned this pull request Jun 5, 2023
Open
30 tasks
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@bnoordhuis@danielleadams
tools: don't gitignore base64 config.h
0b3f5ac
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: #47638 PR-URL: #48174 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@bnoordhuis@MoLow
tools: don't gitignore base64 config.h
361cf8c
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: nodejs#47638 PR-URL: nodejs#48174 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@bnoordhuis@Ceres6
tools: don't gitignore base64 config.h
e9e4929
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: nodejs#47638 PR-URL: nodejs#48174 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@bnoordhuis@Ceres6
tools: don't gitignore base64 config.h
f20633f
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: nodejs#47638 PR-URL: nodejs#48174 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@anonriganonriganonrig approved these changes

@targostargostargos approved these changes

@richardlaurichardlaurichardlau approved these changes

@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

dependenciesPull requests that update a dependency file.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v18.x] broken build with ./configure --shared

7 participants

@bnoordhuis@nodejs-github-bot@lpinca@anonrig@targos@richardlau@marco-ippolito