Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
test: ignore the copied entry_point.c#48297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Add `test_cannot_run_js/entry_point.c` to `test/js-native-api/.gitignore`.
lpinca commented Jun 2, 2023
See node/test/js-native-api/test_cannot_run_js/binding.gyp Lines 3 to 12 in 66f112d
|
targos commented Jun 2, 2023
Do you know why it's copied instead of being referenced directly like in all other tests? |
lpinca commented Jun 2, 2023
I don't know. The test was created like this. cc: @gabrielschulhof |
gabrielschulhof commented Jun 2, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@lpinca@targos somehow, having multiple targets in gyp that refer to a path above the root causes test failures. For example, when I tried to write the binding.gyp file as {"target_defaults":{"sources": [ "../entry_point.c", ] }, "targets": [{"target_name": "test_cannot_run_js", "sources": [ "test_cannot_run_js.c" ], "defines": [ "NAPI_EXPERIMENTAL" ], },{"target_name": "test_pending_exception", "sources": [ "test_cannot_run_js.c" ], "defines": [ "NAPI_VERSION=8" ], } ]I got this failure on https://ci.nodejs.org/job/node-test-commit-osx/52335/nodes=osx11-x64/console and a bunch of other platforms: I tried referring to "../entry_point.c" from each target, and that failed too. In the end, I had no choice but use this convoluted copy-the-file approach. |
nodejs-github-bot commented Jun 3, 2023
nodejs-github-bot commented Jun 3, 2023
nodejs-github-bot commented Jun 3, 2023
nodejs-github-bot commented Jun 5, 2023
nodejs-github-bot commented Jun 6, 2023
nodejs-github-bot commented Jun 6, 2023
nodejs-github-bot commented Jun 6, 2023
Landed in d15652e |
Add `test_cannot_run_js/entry_point.c` to `test/js-native-api/.gitignore`. PR-URL: #48297 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add `test_cannot_run_js/entry_point.c` to `test/js-native-api/.gitignore`. PR-URL: nodejs#48297 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add `test_cannot_run_js/entry_point.c` to `test/js-native-api/.gitignore`. PR-URL: nodejs#48297 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add `test_cannot_run_js/entry_point.c` to `test/js-native-api/.gitignore`. PR-URL: #48297 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add
test_cannot_run_js/entry_point.ctotest/js-native-api/.gitignore.