test: avoid copying test source files#49515
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Converting the helper functions to be inlined and making the helper file header only.
Collaborator
Review requested:
|
nodejs-github-bot added build 
legendecas added test 
lpinca approved these changes Sep 7, 2023
Member
lpinca commented Sep 7, 2023
I would also add a commit that reverts d15652e. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 7, 2023
This reverts commit d15652e.
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Sep 7, 2023
MemberAuthor
legendecas commented Sep 7, 2023
Thanks for the suggestion, applied the revert. |
26 tasks
Collaborator
nodejs-github-bot commented Sep 8, 2023
This was referenced Sep 8, 2023
gabrielschulhof approved these changes Sep 8, 2023
This was referenced Sep 9, 2023
legendecas added commit-queue-rebase nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 10, 2023
Landed in ae115d6...c55625f |
nodejs-github-bot pushed a commit that referenced this pull request Sep 10, 2023
Converting the helper functions to be inlined and making the helper file header only. PR-URL: #49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Sep 10, 2023
This reverts commit d15652e. PR-URL: #49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
18 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
Converting the helper functions to be inlined and making the helper file header only. PR-URL: #49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
This reverts commit d15652e. PR-URL: #49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Converting the helper functions to be inlined and making the helper file header only. PR-URL: nodejs#49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
This reverts commit d15652e. PR-URL: nodejs#49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
Converting the helper functions to be inlined and making the helper file header only. PR-URL: #49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Converting the helper functions to be inlined and making the helper file header only. PR-URL: nodejs/node#49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Converting the helper functions to be inlined and making the helper file header only. PR-URL: nodejs/node#49515 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline the helper functions and make the helper file
header only. So that no files need to be copied during the build (as in
test/js-native-api/test_cannot_run_js/binding.gyp).Refs: #48297 (comment)