Skip to content

node-api: enable uncaught exceptions policy by default#49313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Sep 25, 2023
Merged

node-api: enable uncaught exceptions policy by default #49313

nodejs-github-bot merged 2 commits into from
Sep 25, 2023

Conversation

@legendecas
Copy link
Member

@legendecaslegendecas commented Aug 24, 2023

This enables the option --force-node-api-uncaught-exceptions-policy
for a specific Node-API addon when it is compiled with
NAPI_EXPERIMENTAL (and this would be the default behavior when
NAPI_VERSION 10 releases). This would not break existing Node-API
addons.

Refs: #36510

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2023

Review requested:

  • @nodejs/gyp
  • @nodejs/node-api

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Aug 24, 2023
mhdawson
mhdawson approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawsonmhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 25, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 25, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53555/

@mhdawsonmhdawson mentioned this pull request Aug 25, 2023
Closed
This was referenced Aug 26, 2023
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53776/

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Sep 8, 2023

It would be best to land this after #49515.

@legendecas
node-api: enable uncaught exceptions policy by default
bcda6c4
This enables the option `--force-node-api-uncaught-exceptions-policy` for a specific Node-API addon when it is compiled with `NAPI_EXPERIMENTAL` (and this would be the default behavior when `NAPI_VERSION` 10 releases). This would not break existing Node-API addons.
@legendecaslegendecasforce-pushed the node-api/uncaught-exception branch from 2efb890 to bcda6c4CompareSeptember 11, 2023 17:25
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 12, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53904/

@toyobayashitoyobayashi mentioned this pull request Sep 14, 2023
Merged
gabrielschulhof
gabrielschulhof reviewed Sep 15, 2023
View reviewed changes
test/node-api/test_threadsafe_function/test_uncaught_exception.js Outdated
constbinding=require(`./build/${common.buildType}/binding`);
constbinding=require(`./build/${common.buildType}/test_uncaught_exception`);

constcallbackCheck=common.mustCall((err)=>{
Copy link
Contributor

@gabrielschulhofgabrielschulhofSep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to put this code in a common module? That would make it clear that the same test is supposed to work with both versions, and only the preprocessor flags and the node launch flags differ. I think files not starting with test_ are not executed when the test suite runs.

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 23, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54184/

@github-actionsgithub-actionsbot mentioned this pull request Sep 24, 2023
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 24, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54193/

@legendecaslegendecas added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2023
@nodejs-github-botnodejs-github-bot merged commit 77597d3 into nodejs:mainSep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2023

Landed in 77597d3

@joyeecheungjoyeecheung mentioned this pull request Sep 25, 2023
Closed
@github-actionsgithub-actionsbot mentioned this pull request Sep 27, 2023
Open
21 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@legendecas@ruyadorno
node-api: enable uncaught exceptions policy by default
9600928
This enables the option `--force-node-api-uncaught-exceptions-policy` for a specific Node-API addon when it is compiled with `NAPI_EXPERIMENTAL` (and this would be the default behavior when `NAPI_VERSION` 10 releases). This would not break existing Node-API addons. PR-URL: #49313 Refs: #36510 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
@ruyadornoruyadorno mentioned this pull request Sep 28, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@legendecas@ruyadorno
node-api: enable uncaught exceptions policy by default
96874e8
This enables the option `--force-node-api-uncaught-exceptions-policy` for a specific Node-API addon when it is compiled with `NAPI_EXPERIMENTAL` (and this would be the default behavior when `NAPI_VERSION` 10 releases). This would not break existing Node-API addons. PR-URL: #49313 Refs: #36510 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
@ruyadornoruyadorno mentioned this pull request Sep 28, 2023
Merged
@legendecaslegendecas deleted the node-api/uncaught-exception branch October 24, 2023 06:57
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@legendecas@alexfernandez
node-api: enable uncaught exceptions policy by default
3f39d8c
This enables the option `--force-node-api-uncaught-exceptions-policy` for a specific Node-API addon when it is compiled with `NAPI_EXPERIMENTAL` (and this would be the default behavior when `NAPI_VERSION` 10 releases). This would not break existing Node-API addons. PR-URL: nodejs#49313 Refs: nodejs#36510 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@legendecas@targos
node-api: enable uncaught exceptions policy by default
edef4fa
This enables the option `--force-node-api-uncaught-exceptions-policy` for a specific Node-API addon when it is compiled with `NAPI_EXPERIMENTAL` (and this would be the default behavior when `NAPI_VERSION` 10 releases). This would not break existing Node-API addons. PR-URL: #49313 Refs: #36510 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
node-api: enable uncaught exceptions policy by default
2bba1c9
This enables the option `--force-node-api-uncaught-exceptions-policy` for a specific Node-API addon when it is compiled with `NAPI_EXPERIMENTAL` (and this would be the default behavior when `NAPI_VERSION` 10 releases). This would not break existing Node-API addons. PR-URL: nodejs/node#49313 Refs: nodejs/node#36510 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
node-api: enable uncaught exceptions policy by default
072c20a
This enables the option `--force-node-api-uncaught-exceptions-policy` for a specific Node-API addon when it is compiled with `NAPI_EXPERIMENTAL` (and this would be the default behavior when `NAPI_VERSION` 10 releases). This would not break existing Node-API addons. PR-URL: nodejs/node#49313 Refs: nodejs/node#36510 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielschulhofgabrielschulhofgabrielschulhof approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legendecas@nodejs-github-bot@gabrielschulhof@mhdawson