fs: remove unneeded return statement#48526
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added fs 
lpincaforce-pushed the remove/return-statement branch from 4e3ba1c to d7014d6CompareThe `writable._write()` implementation does not need to return anything, only call the callback.
lpincaforce-pushed the remove/return-statement branch from d7014d6 to 6fb96bbCompare
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jun 22, 2023
30 tasks
Collaborator
nodejs-github-bot commented Jun 23, 2023
Collaborator
nodejs-github-bot commented Jun 23, 2023
Collaborator
nodejs-github-bot commented Jun 23, 2023
kvakil approved these changes Jun 23, 2023
Collaborator
nodejs-github-bot commented Jun 23, 2023
25 tasks
debadree25 approved these changes Jun 24, 2023
debadree25 added author ready github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jun 24, 2023
25 tasks
Collaborator
nodejs-github-bot commented Jun 25, 2023
Collaborator
nodejs-github-bot commented Jun 25, 2023
21 tasks
deokjinkim approved these changes Jun 26, 2023
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 26, 2023
Landed in d09ff0d |
24 tasks
This was referenced Jun 28, 2023
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: #48526 Reviewed-By: Keyhan Vakil <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: nodejs#48526 Reviewed-By: Keyhan Vakil <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: nodejs#48526 Reviewed-By: Keyhan Vakil <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: #48526 Reviewed-By: Keyhan Vakil <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
The `writable._write()` implementation does not need to return anything, only call the callback. PR-URL: #48526 Reviewed-By: Keyhan Vakil <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
writable._write()implementation does not need to return anything, only call the callback.