benchmark: fix webstream pipe-to#49552
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the benchmark 
rluvaton commented Sep 8, 2023
| highWaterMark: highWaterMarkR, | ||
| pull: function(controller){ | ||
| if(i++===n){ | ||
| if(i++<n){ |
MemberAuthor
There was a problem hiding this comment.
If I understand correctly, this does not call enqueue as it closes the stream immediately
Contributor
Fast-track has been requested by @rluvaton. Please 👍 to approve. |
ronag approved these changes Sep 8, 2023
rluvaton added the author ready 
atlowChemi approved these changes Sep 8, 2023
rluvaton added the commit-queue nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented Sep 8, 2023
Landed in 7bf29b5 |
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
PR-URL: #49552 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#49552 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.