Skip to content

benchmark: fix webstream pipe-to#49552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Sep 8, 2023
Merged

benchmark: fix webstream pipe-to #49552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/webstreams/pipe-to.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ async function main({n, highWaterMarkR, highWaterMarkW }){
const rs = new ReadableStream({
highWaterMark: highWaterMarkR,
pull: function(controller){
if (i++ === n){
if (i++ < n){
Copy link
MemberAuthor

@rluvatonrluvatonSep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this does not call enqueue as it closes the stream immediately

controller.enqueue(b);
} else{
controller.close();
Expand Down