Skip to content

esm: require braces for modules code#49657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 5 commits into from
Sep 15, 2023
Merged

esm: require braces for modules code #49657

nodejs-github-bot merged 5 commits into from
Sep 15, 2023

Conversation

@GeoffreyBooth
Copy link
Member

@GeoffreyBoothGeoffreyBooth commented Sep 14, 2023

Split out from #49523 per #49523 (comment).

This PR adds a lint rule to formalize our informal rule for modules code, where we try to always use braces to enclose blocks (so no implicit blocks after things like if conditions).

@GeoffreyBoothGeoffreyBooth added esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 14, 2023

Review requested:

  • @nodejs/loaders

@github-actions
Copy link
Contributor

github-actionsbot commented Sep 14, 2023

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 14, 2023
aduh95
aduh95 approved these changes Sep 14, 2023
View reviewed changes
@GeoffreyBoothGeoffreyBooth mentioned this pull request Sep 15, 2023
Merged
aduh95
aduh95 reviewed Sep 15, 2023
View reviewed changes
@aduh95aduh95force-pushed the modules-code-add-braces branch from 3be8276 to 9e3e794CompareSeptember 15, 2023 08:14
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 15, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53959/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53960/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53969/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2023
@GeoffreyBoothGeoffreyBooth added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 15, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2023
@nodejs-github-botnodejs-github-bot merged commit f42a103 into nodejs:mainSep 15, 2023
This was referenced Sep 17, 2023
Open
Open
Open
@ruyadorno
Copy link
Member

ruyadorno commented Sep 28, 2023

This commit does not land cleanly on v20.x-staging and will need manual backport in case we want it in v20.

@ruyadornoruyadorno added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Sep 28, 2023
@RafaelGSSRafaelGSS mentioned this pull request Oct 9, 2023
Merged
GeoffreyBooth added a commit to GeoffreyBooth/node that referenced this pull request Oct 19, 2023
@GeoffreyBooth
esm: require braces for modules code
fc934ad
PR-URL: nodejs#49657 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
@GeoffreyBoothGeoffreyBooth mentioned this pull request Oct 19, 2023
Closed
@GeoffreyBoothGeoffreyBooth added backport-open-v20.x Indicate that the PR has an open backport and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels Oct 19, 2023
GeoffreyBooth added a commit to GeoffreyBooth/node that referenced this pull request Oct 19, 2023
@GeoffreyBooth
esm: require braces for modules code
83e582a
PR-URL: nodejs#49657 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@GeoffreyBooth@alexfernandez
esm: require braces for modules code
f143c29
PR-URL: nodejs#49657 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@GeoffreyBooth@targos
esm: require braces for modules code
f306158
PR-URL: nodejs#49657 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
@targostargos mentioned this pull request Nov 11, 2023
Closed
@targostargos added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed backport-open-v20.x Indicate that the PR has an open backport labels Nov 11, 2023
targos pushed a commit that referenced this pull request Nov 11, 2023
@GeoffreyBooth@targos
esm: require braces for modules code
0103979
PR-URL: #49657 Backport-PR-URL: #50268 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@GeoffreyBooth@targos
esm: require braces for modules code
c262d3b
PR-URL: nodejs#49657 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 23, 2023
@GeoffreyBooth@targos
esm: require braces for modules code
957725f
PR-URL: #49657 Backport-PR-URL: #50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
ckerr added a commit to electron/electron that referenced this pull request Dec 7, 2023
@ckerr
chore: update pass_all_globals_through_require.patch
2d3c55f
no manual changes; patch applied with fuzz Xref: nodejs/node#49657
ckerr added a commit to electron/electron that referenced this pull request Dec 7, 2023
@ckerr
update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
d44b426
Xref: nodejs/node#50096 Xref: nodejs/node#50314 in lib/internal/modules/esm/load.js, update the code that checks for `format === 'electron'`. I'd like 👀 on this Xref: nodejs/node#49657 add braces in lib/internal/modules/esm/translators.js to sync with upstream
codebytere pushed a commit to electron/electron that referenced this pull request Dec 8, 2023
@ckerr@codebytere
chore: update pass_all_globals_through_require.patch
9e47ee7
no manual changes; patch applied with fuzz Xref: nodejs/node#49657
codebytere pushed a commit to electron/electron that referenced this pull request Dec 8, 2023
@ckerr@codebytere
update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch
077c8e4
Xref: nodejs/node#50096 Xref: nodejs/node#50314 in lib/internal/modules/esm/load.js, update the code that checks for `format === 'electron'`. I'd like 👀 on this Xref: nodejs/node#49657 add braces in lib/internal/modules/esm/translators.js to sync with upstream
codebytere added a commit to electron/electron that referenced this pull request Dec 11, 2023
@electron-roller@ckerr@codebytere
chore: bump node to v20.10.0 (main) (#40675)
890a557
* chore: bump node in DEPS to v20.10.0 * chore: update feat_initialize_asar_support.patch no code changes; patch just needed an update due to nearby upstream changes Xref: nodejs/node#49986 * chore: update pass_all_globals_through_require.patch no manual changes; patch applied with fuzz Xref: nodejs/node#49657 * chore: update refactor_allow_embedder_overriding_of_internal_fs_calls Xref: nodejs/node#49912 no code changes; patch just needed an update due to nearby upstream changes * chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch Xref: nodejs/node#49986 minor manual changes needed to sync with upstream change * update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#50096 Xref: nodejs/node#50314 in lib/internal/modules/esm/load.js, update the code that checks for `format === 'electron'`. I'd like 👀 on this Xref: nodejs/node#49657 add braces in lib/internal/modules/esm/translators.js to sync with upstream * fix: lazyload fs in esm loaders to apply asar patches * nodejs/node#50127 * nodejs/node#50096 * esm: jsdoc for modules code nodejs/node#49523 * test: set test-cli-node-options as flaky nodejs/node#50296 * deps: update c-ares to 1.20.1 nodejs/node#50082 * esm: bypass CommonJS loader under --default-type=module nodejs/node#49986 * deps: update uvwasi to 0.0.19 nodejs/node#49908 * lib,test: do not hardcode Buffer.kMaxLength nodejs/node#49876 * crypto: account for disabled SharedArrayBuffer nodejs/node#50034 * test: fix edge snapshot stack traces nodejs/node#49659 * src: generate snapshot with --predictable nodejs/node#48749 * chore: fixup patch indices * fs: throw errors from sync branches instead of separate implementations nodejs/node#49913 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * esm: detect ESM syntax in ambiguous JavaScrip nodejs/node#50096 * fixup! test: fix edge snapshot stack traces * esm: unflag extensionless ES module JavaScript and Wasm in module scope nodejs/node#49974 * [tagged-ptr] Arrowify objects https://chromium-review.googlesource.com/c/v8/v8/+/4705331 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <[email protected]> Co-authored-by: Shelley Vohr <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: require braces for modules code
009f613
PR-URL: nodejs/node#49657 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: require braces for modules code
4dc712f
PR-URL: nodejs/node#49657 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes

@ljharbljharbljharb approved these changes

@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backported-to-v20.xPRs backported to the v20.x-staging branch.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.fast-trackPRs that do not need to wait for 48 hours to land.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GeoffreyBooth@nodejs-github-bot@ruyadorno@ljharb@JakobJingleheimer@aduh95@targos