lib,test: do not hardcode Buffer.kMaxLength#49876
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
V8 will soon support typed arrays as large as the maximum array buffer length. This patch replaces hardcoded values related to Buffer.kMaxLength with the actual constant. It also fixes a test that was passing by accident. Refs: v8/v8@44b2995
richardlau approved these changes Sep 26, 2023
lpinca approved these changes Sep 26, 2023
anonrig approved these changes Sep 26, 2023
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Sep 26, 2023
anonrig added the author ready Collaborator
nodejs-github-bot commented Sep 27, 2023
19 tasks
Collaborator
nodejs-github-bot commented Sep 28, 2023
debadree25 added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Sep 28, 2023
Landed in a4fdb1a |
targos added a commit to targos/node that referenced this pull request Sep 28, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs#49876 Refs: nodejs/node-v8#268
targos added a commit that referenced this pull request Sep 30, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: #49876 Refs: nodejs/node-v8#268
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 1, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 2, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
jkleinsc added a commit to electron/electron that referenced this pull request Oct 2, 2023
jkleinsc added a commit to electron/electron that referenced this pull request Oct 2, 2023
* chore: bump chromium in DEPS to 119.0.6036.0 * chore: bump chromium in DEPS to 119.0.6037.0 * chore: bump chromium in DEPS to 119.0.6039.0 * chore: bump chromium in DEPS to 119.0.6041.0 * chore: update chromium patches * 4765230: Move //content/browser/renderer_host/event_with_latency_info.h to //content/common/input | https://chromium-review.googlesource.com/c/chromium/src/+/4765230 * 4890325: ScopedRunLoopTimeout: add custom timeout callback handler for testing | https://chromium-review.googlesource.com/c/chromium/src/+/4890325 * chore: update all patches * chore: bump chromium in DEPS to 119.0.6043.0 * 4898682: [api] Add Error.cause to V8 API https://chromium-review.googlesource.com/c/v8/v8/+/4898682 * 4837192: Plumb origin through for drags. https://chromium-review.googlesource.com/c/chromium/src/+/4837192 * Prevent content analysis on web pages that don't accept drag and drop. https://chromium-review.googlesource.com/c/chromium/src/+/4814086 * Make getting displayed notifications work with notification attribution. https://chromium-review.googlesource.com/c/chromium/src/+/4738935 * 4898682: [api] Add Error.cause to V8 API https://chromium-review.googlesource.com/c/v8/v8/+/4898682 * lib,test: do not hardcode Buffer.kMaxLength nodejs/node#49876 * chore: remove Goma warning from mksnapshot_args * 4776412: Remove Windows-specific wstring variants of StringPrintf() etc. https://chromium-review.googlesource.com/c/chromium/src/+/4776412 * [dPWA] Prevent WebAppInstallInfo from being included on Android https://chromium-review.googlesource.com/c/chromium/src/+/4886594 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: VerteDinde <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 3, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 4, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 5, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 6, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 7, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 8, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 9, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 10, 2023
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs/node#49876 Refs: #268
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
V8 will soon support typed arrays as large as the maximum array buffer length. This patch replaces hardcoded values related to Buffer.kMaxLength with the actual constant. It also fixes a test that was passing by accident. Refs: v8/v8@44b2995 PR-URL: nodejs#49876 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos added a commit that referenced this pull request Nov 11, 2023
V8 will soon support typed arrays as large as the maximum array buffer length. This patch replaces hardcoded values related to Buffer.kMaxLength with the actual constant. It also fixes a test that was passing by accident. Refs: v8/v8@44b2995 PR-URL: #49876 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Dec 8, 2023
codebytere added a commit to electron/electron that referenced this pull request Dec 8, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
* chore: bump chromium in DEPS to 119.0.6036.0 * chore: bump chromium in DEPS to 119.0.6037.0 * chore: bump chromium in DEPS to 119.0.6039.0 * chore: bump chromium in DEPS to 119.0.6041.0 * chore: update chromium patches * 4765230: Move //content/browser/renderer_host/event_with_latency_info.h to //content/common/input | https://chromium-review.googlesource.com/c/chromium/src/+/4765230 * 4890325: ScopedRunLoopTimeout: add custom timeout callback handler for testing | https://chromium-review.googlesource.com/c/chromium/src/+/4890325 * chore: update all patches * chore: bump chromium in DEPS to 119.0.6043.0 * 4898682: [api] Add Error.cause to V8 API https://chromium-review.googlesource.com/c/v8/v8/+/4898682 * 4837192: Plumb origin through for drags. https://chromium-review.googlesource.com/c/chromium/src/+/4837192 * Prevent content analysis on web pages that don't accept drag and drop. https://chromium-review.googlesource.com/c/chromium/src/+/4814086 * Make getting displayed notifications work with notification attribution. https://chromium-review.googlesource.com/c/chromium/src/+/4738935 * 4898682: [api] Add Error.cause to V8 API https://chromium-review.googlesource.com/c/v8/v8/+/4898682 * lib,test: do not hardcode Buffer.kMaxLength nodejs/node#49876 * chore: remove Goma warning from mksnapshot_args * 4776412: Remove Windows-specific wstring variants of StringPrintf() etc. https://chromium-review.googlesource.com/c/chromium/src/+/4776412 * [dPWA] Prevent WebAppInstallInfo from being included on Android https://chromium-review.googlesource.com/c/chromium/src/+/4886594 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: VerteDinde <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Dec 11, 2023
* chore: bump node in DEPS to v20.10.0 * chore: update feat_initialize_asar_support.patch no code changes; patch just needed an update due to nearby upstream changes Xref: nodejs/node#49986 * chore: update pass_all_globals_through_require.patch no manual changes; patch applied with fuzz Xref: nodejs/node#49657 * chore: update refactor_allow_embedder_overriding_of_internal_fs_calls Xref: nodejs/node#49912 no code changes; patch just needed an update due to nearby upstream changes * chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch Xref: nodejs/node#49986 minor manual changes needed to sync with upstream change * update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#50096 Xref: nodejs/node#50314 in lib/internal/modules/esm/load.js, update the code that checks for `format === 'electron'`. I'd like 👀 on this Xref: nodejs/node#49657 add braces in lib/internal/modules/esm/translators.js to sync with upstream * fix: lazyload fs in esm loaders to apply asar patches * nodejs/node#50127 * nodejs/node#50096 * esm: jsdoc for modules code nodejs/node#49523 * test: set test-cli-node-options as flaky nodejs/node#50296 * deps: update c-ares to 1.20.1 nodejs/node#50082 * esm: bypass CommonJS loader under --default-type=module nodejs/node#49986 * deps: update uvwasi to 0.0.19 nodejs/node#49908 * lib,test: do not hardcode Buffer.kMaxLength nodejs/node#49876 * crypto: account for disabled SharedArrayBuffer nodejs/node#50034 * test: fix edge snapshot stack traces nodejs/node#49659 * src: generate snapshot with --predictable nodejs/node#48749 * chore: fixup patch indices * fs: throw errors from sync branches instead of separate implementations nodejs/node#49913 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * esm: detect ESM syntax in ambiguous JavaScrip nodejs/node#50096 * fixup! test: fix edge snapshot stack traces * esm: unflag extensionless ES module JavaScript and Wasm in module scope nodejs/node#49974 * [tagged-ptr] Arrowify objects https://chromium-review.googlesource.com/c/v8/v8/+/4705331 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <[email protected]> Co-authored-by: Shelley Vohr <[email protected]>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
V8 will soon support typed arrays as large as the maximum array buffer length. This patch replaces hardcoded values related to Buffer.kMaxLength with the actual constant. It also fixes a test that was passing by accident. Refs: v8/v8@44b2995 PR-URL: nodejs#49876 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 will soon support typed arrays as large as the maximum array buffer length. This patch replaces hardcoded values related to Buffer.kMaxLength with the actual constant.
It also fixes a test that was passing by accident.
Refs: v8/v8@44b2995