Skip to content

src: limit Buffer::kMaxLength to 1TB#49930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 2 commits into from
Closed

src: limit Buffer::kMaxLength to 1TB #49930

targos wants to merge 2 commits into from

Conversation

@targos
Copy link
Member

@targostargos commented Sep 28, 2023•
edited
Loading

This change has no real effect for now, as the V8 maximum typed array
length is still 2**32. When V8 is updated to version 11.9 or later, the
limit will be 2**53-1 on 64-bit architectures, much larger than any
reasonable amount of RAM. This caps the limit at 1TB, which is already
very large and corresponds to the maximum memory that AddressSanitizer
allows to allocate.

Refs: #49876
Refs: nodejs/node-v8#268

@targos
src: limit Buffer::kMaxLength to 1TB
12f841d
This change has no real effect for now, as the V8 maximum typed array length is still 2**32. When V8 is updated to version 11.9 or later, the limit will be 2**53-1 on 64-bit architectures, much larger than any reasonable amount of RAM. This caps the limit at 1TB, which is already very large and corresponds to the maximum memory that AddressSanitizer allows to allocate. Refs: nodejs#49876 Refs: nodejs/node-v8#268
@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 28, 2023
@targostargos mentioned this pull request Sep 28, 2023
Closed
anonrig
anonrig reviewed Sep 28, 2023
View reviewed changes
bnoordhuis
bnoordhuis approved these changes Sep 28, 2023
View reviewed changes
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 30, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54396/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54399/

@targos
Copy link
MemberAuthor

targos commented Sep 30, 2023

I had to push a fixup commit, because v8::TypedArray::kMaxLength is deprecated in V8 11.9 (and for consistency).

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54404/

This was referenced Oct 1, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 2, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54453/

@targostargos marked this pull request as draft October 2, 2023 14:08
@targos
Copy link
MemberAuthor

targos commented Oct 2, 2023

Converted to draft because the issue with ASAN isn't fixed by this and while reducing the limit further would be enough, canary builds show other issues related to this change: nodejs/node-v8#268 (comment)

@targostargos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2023
This was referenced Oct 3, 2023
Open
Open
Open
@targos
Copy link
MemberAuthor

targos commented Oct 10, 2023

Will revisit this in the V8 11.9 update PR.

@targostargos closed this Oct 10, 2023
@targostargos mentioned this pull request Oct 10, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@targos@nodejs-github-bot@bnoordhuis@anonrig