perf_hooks: reduce overhead of new resource timings#49837
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the work started on nodejs/performance#109.
This PR should be landed after #49803.
I want to use the symbolkSkipThrowin other classes around the NodeJS codebase, someone had some idea where I should put it? Or create a new symbol and reuse it when possible?Right now, we have this symbol being used onperf_hooksbut there is also an identical symbol onwebstreams, so maybe we can put it in a higher module and import it around the node, I initially thought to put it insideerrors, since we will always use it together withERR_ILLEGAL_CONSTRUCTOR.I will reuse the same symbol only when it inherits some class that exports a symbol, otherwise, I will create a new one.
/cc @nodejs/performance