Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
CollaboratorAuthor
nodejs-github-bot commented Oct 1, 2023
Review requested:
|
lpincaforce-pushed the actions/tools-update-doc branch from bcca2e8 to af4b2d9Compare
MoLow approved these changes Oct 1, 2023
lpinca approved these changes Oct 1, 2023
Member
lpinca commented Oct 3, 2023
I'm not sure why the coverage job fails. Can we ignore it? |
lpincaforce-pushed the actions/tools-update-doc branch from af4b2d9 to 7710af5Compare
nodejs-github-bot changed the title 
aduh95force-pushed the actions/tools-update-doc branch from 6d492c8 to 269c8b8Compareaduh95 added author ready 
aduh95force-pushed the actions/tools-update-doc branch from 269c8b8 to bcad579Compare
aduh95 approved these changes Oct 26, 2023
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue CollaboratorAuthor
nodejs-github-bot commented Oct 26, 2023
Landed in 6431c65 |
Member
I think this has broken the without-intl build: 17:31:46 npm WARN cli npm v10.2.0 does not support Node.js v22.0.0-pre. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.17:31:47 17:31:47 added 109 packages, and audited 110 packages in 1s17:31:47 17:31:47 94 packages are looking for funding17:31:47 run `npm fund` for details17:31:47 17:31:47 found 0 vulnerabilities17:31:47 file:///home/iojs/build/workspace/node-test-commit-linux-containered/tools/doc/node_modules/micromark-util-character/index.js:517:31:47 const unicodePunctuationInternal = regexCheck(/\p{P}/u)17:31:47 ^^^^^^^^17:31:47 17:31:47 SyntaxError: Invalid regular expression: /\p{P}/u: Invalid property name17:31:47 at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:155:18)17:31:47 at callTranslator (node:internal/modules/esm/loader:285:14)17:31:47 at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:291:30)17:31:47 17:31:47 Node.js v22.0.0-pre17:31:47 /bin/sh: 5: node: not found17:31:47 Makefile:374: recipe for target 'test/addons/.docbuildstamp' failedOpened a revert: #50414 |
5 tasks
This was referenced Oct 26, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] PR-URL: nodejs#49988 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] PR-URL: #49988 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] PR-URL: #49988 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of doc to [email protected][email protected][email protected][email protected][email protected][email protected][email protected].