Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
Revert "tools: update doc dependencies"#50414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This reverts commit 6431c65.
nodejs-github-bot commented Oct 26, 2023
Review requested:
|
nodejs-github-bot commented Oct 26, 2023
joyeecheung commented Oct 26, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Separated from this (which I think should land ASAP), I wonder if we should just skip doc generation/tests in without-intl builds |
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
richardlau commented Oct 26, 2023
That was a suggestion in #35942 (comment), which references #41091 which I'm now confused over as it suggests we shouldn't be attempting to generate docs without intl available? Maybe either something was missed there or we've subsequently changed something in how the docs are generated that means they're no longer being skipped? 🤔 |
nodejs-github-bot commented Oct 26, 2023
nodejs-github-bot commented Oct 26, 2023
Landed in 67b1383 |
joyeecheung commented Oct 27, 2023
Do we have other Node.js installations available in the system? #41091 checks the availability of intl using whatever Node.js binary available in the system ( |
joyeecheung commented Oct 27, 2023
hmm, I think this is caused by a missing dependency check in |
joyeecheung commented Oct 27, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
So it seems the cause is that:
Not sure how this can be addressed easily. I think we do still want to test the addons in addons.md in without-intl builds. Perhaps we can just use some dumb marker in addons.md to denote where the code examples are and write a custom parser instead of using remark. |
This reverts commit 6431c65. PR-URL: nodejs#50414 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This reverts commit 6431c65. PR-URL: #50414 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This reverts commit 6431c65. PR-URL: #50414 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This reverts commit 6431c65.
Refs: #49988 (comment)
This is a quick revert to fix the without-intl builds on the Jenkins CI. If someone else has a better fix that can be landed quickly, feel free to close this one.