+386 −231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
CollaboratorAuthor
nodejs-github-bot commented Oct 29, 2023
Review requested:
|
github-actionsbot removed the request-ci CollaboratorAuthor
nodejs-github-bot commented Oct 29, 2023
CollaboratorAuthor
nodejs-github-bot commented Oct 29, 2023
MoLow previously approved these changes Oct 29, 2023
Member
lpinca commented Oct 29, 2023
See #50414. |
25 tasks
Contributor
aduh95 commented Oct 30, 2023
I think the logical fix is to build the docs with a stable |
Member
richardlau commented Oct 30, 2023
@aduh95 FWIW the without-intl job runs: NODE_TEST_DIR=/home/iojs/node-tmp FLAKY_TESTS=dontcare CONFIG_FLAGS=' --without-intl' make run-ci -j 4Given that we describe how to build without intl in https://github.com/nodejs/node/blob/main/BUILDING.md#building-without-intl-support I'd prefer if we had a solution that worked without involving changes to the Jenkins job -- i.e. running the Makefile after |
17 tasks
jasnell approved these changes Nov 11, 2023
nodejs-github-bot changed the title 
aymen94 approved these changes Nov 30, 2023
aduh95force-pushed the actions/tools-update-doc branch from 002a698 to 88b53ddCompareaduh95 added author ready github-actionsbot removed the request-ci CollaboratorAuthor
nodejs-github-bot commented Dec 10, 2023
aduh95 approved these changes Dec 11, 2023
Contributor
aduh95 commented Dec 11, 2023
Landed in ab93a35 |
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
And [email protected]. PR-URL: #50459 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
And [email protected]. PR-URL: #50459 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of doc to [email protected]
[email protected][email protected][email protected][email protected][email protected](updating those breaks the no-intl CI) [email protected][email protected].