(vee-eight-4.9) replace usage of deprecated V8 APIs#5159
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
targos added c++ 
Member
bnoordhuis commented Feb 9, 2016
LGTM with style suggestions. Good work. |
MemberAuthor
targos commented Feb 10, 2016
CI: https://ci.nodejs.org/job/node-test-pull-request/1625/ Should I squash everything into one commit (and list the changes in the message) before landing ? |
Member
bnoordhuis commented Feb 10, 2016
Whatever you prefer. I'd be okay with keeping the commits separate, might be easier if we need to bisect. |
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request Feb 11, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
ofrobots pushed a commit that referenced this pull request Mar 4, 2016
PR-URL: #5159 Reviewed-By: Ben Noordhuis <[email protected]>
Contributor
Fishrock123 commented Mar 7, 2016
To confirm, is this safe to land in v5.x? (Please reply in #5559) |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not touch SetWeak and SetAccessor yet (will need help for those).
Ref: #4869
cc @nodejs/v8