src: switch from ToLocalChecked to ToLocal in node_webstorage#53959
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
jasnellforce-pushed the fixup-node-webstorage-tolocalchecked branch from 531fe5a to 66d9d0dCompare
juanarbol approved these changes Jul 19, 2024
Member
juanarbol left a comment
juanarbol left a comment There was a problem hiding this comment.
lgtm
I saw something like this a couple weeks ago… r u fuzzing Node?
cjihrig approved these changes Jul 20, 2024
jasnellforce-pushed the fixup-node-webstorage-tolocalchecked branch from 66d9d0d to 795c8a4Compare
anonrig approved these changes Jul 21, 2024
github-actionsbot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
jasnell added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 21, 2024
Landed in eb85db4 |
targos pushed a commit that referenced this pull request Jul 28, 2024
PR-URL: #53959 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
PR-URL: #53959 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos added the dont-land-on-v20.x 
nodejs-github-bot pushed a commit that referenced this pull request Nov 27, 2025
PR-URL: #60846 Refs: #53959 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2025
PR-URL: #60846 Refs: #53959 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.