src: simply uint32 to string as it must not fail#60846
Merged
+25 −75
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8::Uint32::ToStringdoes not return an empty local handle. V8 internalNumberToStringdoes not return an empty handle. It should be safe to assert innode::Uint32ToStringthat this function returns a non empty string handle, and remove the redundant error recovering logics.Refs: #53959