test: fix invalid file: URL in test-fs-path-dir#55454
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #55454 +/- ## ======================================= Coverage 88.40% 88.41% ======================================= Files 653 653 Lines 187600 187505 -95 Branches 36117 36100 -17 ======================================= - Hits 165854 165777 -77 + Misses 14974 14967 -7 + Partials 6772 6761 -11 |
LiviaMedeiros approved these changes Oct 19, 2024
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 19, 2024
aduh95 added the author ready 
jakecastelli approved these changes Oct 19, 2024
Collaborator
nodejs-github-bot commented Oct 19, 2024
aduh95 added the commit-queue 
lpinca approved these changes Oct 19, 2024
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Oct 21, 2024
Landed in 7e60b5e |
aduh95 added a commit that referenced this pull request Oct 23, 2024
PR-URL: #55454 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55454 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55454 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
ruyadorno commented Nov 27, 2024
This commit does not land cleanly on |
ruyadorno added the backport-requested-v22.x aduh95 added dont-land-on-v18.x dont-land-on-v20.x Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to build a URL by concatenating
file://and a path will always fail as soon as the path contains some URL-significant char (e.g.%,?,#)