V23.1.0 proposal#55513
Merged
V23.1.0 proposal #55513
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This should make easier to read on benchmark/compare and when generating graphs PR-URL: #55254 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.9.1 to 2.10.1. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@5c7944e...91182cc) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #55220 Reviewed-By: Luigi Pinca <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.6 to 3.26.10. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4dd1613...e2b3eaf) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #55221 Reviewed-By: Luigi Pinca <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@e28ff12...b9fd7d1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #55222 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55191 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55348 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]>
The two proposals reached stage 4 at the October 2024 meeting. PR-URL: #55333 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #50853Fixes: #50836 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This commit lets `tranfer` passed to `structuredClone` get validated at JS layer by doing webidl conversion. This avoids the C++ to JS function call overhead in the native implementaiton of `structuredClone` PR-URL: #55317Fixes: #55280 Refs: #50330 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
PR-URL: #55361 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #55273 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
fix make errors that occur in coverage-clean case and coverage-test in Makefile PR-URL: #55287 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
update test_util.cc for code coverage src/util-inl.h:PopFront() PR-URL: #55291 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refs: https://github.com/libuv/libuv/releases/tag/v1.49.1 PR-URL: #55114 Refs: https://github.com/libuv/libuv/releases/tag/v1.49.0 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This reverts commit 42e659c. PR-URL: #55114 Refs: https://github.com/libuv/libuv/releases/tag/v1.49.0 Refs: https://github.com/libuv/libuv/releases/tag/v1.49.1 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
As now the `SQPOLL` ring used in the libuv io_uring implementation is disabled by default. Also modify `UvMightBeUsingIoUring()` to just handle the case where `Node.js` is dynamically linked to a `libuv` version which has the `SQPOLL` ring enabled. PR-URL: #55114 Refs: https://github.com/libuv/libuv/releases/tag/v1.49.0 Refs: https://github.com/libuv/libuv/releases/tag/v1.49.1 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55312Fixes: #55311 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #55116 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
PR-URL: #55295 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55359 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #55354 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #55369 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Refs: v8/v8@12.9.202.26...12.9.202.28 PR-URL: #55371 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Fixes: #23191 PR-URL: #55207 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55356 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
While the statement is running, it is impossible to modify the column names and thus it is beneficial to create the host-language (JS) keys once per all rows and reuse them for all results. With this change the performance of `.all()` improves by around 25% depending on the number of columns and rows in the result. PR-URL: #55373 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #55375 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
PR-URL: #55061 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fixes: #52195 PR-URL: #55377 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #55379 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs-github-bot added meta 
aduh95 added request-ci 
github-actionsbot removed the request-ci 
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/63274/ |
Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) #55398 PR-URL: #55513
JakobJingleheimer approved these changes Oct 24, 2024
ronag approved these changes Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## v23.x #55513 +/- ## ========================================== + Coverage 88.40% 88.42% +0.01% ========================================== Files 652 653 +1 Lines 186784 187479 +695 Branches 36056 36089 +33 ========================================== + Hits 165130 165769 +639 - Misses 14903 14955 +52 - Partials 6751 6755 +4
|
avivkeller added release 
richardlau approved these changes Oct 24, 2024
aduh95 added a commit that referenced this pull request Oct 24, 2024
Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) #55398 PR-URL: #55513
aduh95 added a commit to aduh95/nodejs.org that referenced this pull request Oct 24, 2024
5 tasks
github-merge-queuebot pushed a commit to nodejs/nodejs.org that referenced this pull request Oct 24, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) nodejs#54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) nodejs#55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) nodejs#55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) nodejs#55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) nodejs#55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) nodejs#55398 PR-URL: nodejs#55513
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
Notable changes: assert: * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) nodejs#54862 buffer: * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) nodejs#55377 esm: * mark import attributes and JSON module as stable (Nicolò Ribaudo) nodejs#55333 lib: * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) nodejs#55403 net: * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) nodejs#55408 test_runner: * mark `MockTimers` as stable (Erick Wendel) nodejs#55398 PR-URL: nodejs#55513
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffernow work with resizableArrayBufferWhen a
Bufferis created using a resizableArrayBuffer, theBufferlengthwill now correctly change as the underlying
ArrayBuffersize is changed.Contributed by James M Snell in #55377.
MockTimerstest runner API is now stableMockTimers, introduced in April 2023, has just reached stable status. ThisAPI provides comprehensive support for mocking
Dateand all major timers inNode.js, including
setTimeout,setInterval, andsetImmediate, both fromthe
node:timers,node:timers/promisesmodules and global objects. Aftermonths of refinement, developers can now fully rely on
MockTimersfor testingtime-based operations with confidence, ensuring better control over asynchronous
behavior in their Node.js applications.
Example usage with initial
Dateobject as time set:Contributed by Erick Wendel in #55398.
JSON modules and import attributes are now stable
The two proposals reached stage 4 of the TC39 process, at the October 2024
meeting. The Node.js implementation already matches exactly the semantics
required by the proposals.
Contributed by Nicolò Ribaudo by #55333.
Other Notable Changes
4ba31b7f20] - (SEMVER-MINOR)assert: makeassertion_erroruse Myers diff algorithm (Giovanni Bucci) #54862dcbc5fbe65] - (SEMVER-MINOR)lib: addUV_UDP_REUSEPORTfor udp (theanarkh) #55403ec867ac7ce] - (SEMVER-MINOR)net: addUV_TCP_REUSEPORTfor tcp (theanarkh) #55408Commits
4ba31b7f20] - (SEMVER-MINOR)assert: make assertion_error use Myers diff algorithm (Giovanni Bucci) #54862fe667bea28] - assert: fix deepEqual always return true on URL (Xuguang Mei) #50853aca03d9083] - benchmark: add --runs support to run.js (Rafael Gonzaga) #55158c5abf50692] - benchmark: adjust byte size for buffer-copy (Rafael Gonzaga) #55295d3618b2334] - benchmark: adjust config for deepEqual object (Rafael Gonzaga) #55254c05582da3d] - (SEMVER-MINOR)buffer: make Buffer work with resizable ArrayBuffer (James M Snell) #55377194bb0fca5] - build: fix GN build for cares/uv deps (Cheng) #554778eb5359592] - build: fix uninstall script for AIX 7.1 (Cloorc) #5543832f7d5ad1c] - build: conditionally compile bundled sqlite (Richard Lau) #554092147e496e7] - build: tidy up cares.gyp (Richard Lau) #554452beae50c77] - build: synchronize list of c-ares source files (Richard Lau) #55445f48d30eb9f] - build: fix path concatenation (Mohammed Keyvanzadeh) #55387d42522eec5] - build: fix make errors that occur in Makefile (minkyu_kim) #5528752da293471] - cli: add--heap-profflag available toNODE_OPTIONS(Juan José) #54259adead26815] - crypto: include openssl/rand.h explicitly (Shelley Vohr) #55425df2f1adf9e] - deps: V8: cherry-pick f915fa4c9f41 (Chengzhong Wu) #55484bfc10a975f] - deps: update googletest to df1544b (Node.js GitHub Bot) #5546545ef1809bd] - deps: update c-ares to v1.34.2 (Node.js GitHub Bot) #55463c2b5ebfeca] - deps: update ada to 2.9.1 (Node.js GitHub Bot) #54679903863cafa] - deps: update simdutf to 5.6.0 (Node.js GitHub Bot) #55379008fb5f7f4] - deps: patch V8 to 12.9.202.28 (Node.js GitHub Bot) #553718b282228ae] - deps: update c-ares to v1.34.1 (Node.js GitHub Bot) #5536954d55f2337] - Revert "deps: disable io_uring support in libuv by default" (Santiago Gimeno) #55114bfb3c621c4] - deps: update libuv to 1.49.1 (Santiago Gimeno) #55114055d2b8919] - deps: update amaro to 0.1.9 (Node.js GitHub Bot) #55348c028d21b44] - diagnostics_channel: fix unsubscribe during publish (simon-id) #55116b4b6ddb777] - dns: honor the order option (Luigi Pinca) #5539237352cef7f] - doc: changed the command used to verify SHASUMS256 (adriancuadrado) #5542066bcf4c065] - doc: move dual package shipping docs to separate repo (Joyee Cheung) #5544404b41bda03] - doc: add note about stdio streams in child_process (Ederin (Ed) Igharoro) #55322689d3a3e41] - doc: addisBigIntObjectto documentation (leviscar) #55450784c825a27] - doc: remove outdated remarks abouthighWaterMarkin fs (Ian Kerins) #554621ec25e8573] - doc: move Danielle Adams key to old gpg keys (RafaelGSS) #553997d5bb097eb] - doc: move Bryan English key to old gpg keys (RafaelGSS) #553992967471f67] - doc: move Beth Griggs keys to old gpg keys (RafaelGSS) #553990be3a7505f] - doc: add changelog for mocktimers (Erick Wendel) #55398e15f779794] - doc: spell out condition restrictions (Jan Martin) #55187c3f2216a7d] - doc: add instructions for WinGet build (Hüseyin Açacak) #55356bdc2c3bb94] - doc: add missing return values in buffer docs (Karl Horky) #5527341f68f59af] - doc: fix ambasador markdown list (Rafael Gonzaga) #55361bbd5318729] - esm: add a fallback when importer in not a file (Antoine du Hamel) #5547122d77773fd] - esm: fix inconsistency withimportAssertioninresolvehook (Wei Zhu) #5536548bb87b059] - esm: mark import attributes and JSON module as stable (Nicolò Ribaudo) #553338ceefebaf2] - events: optimize EventTarget.addEventListener (Robert Nagy) #5531245f960cab6] - fs: pass correct path toDirentFromStatsduringglob(Aviv Keller) #55071d9494a7641] - fs: usewstringon Windows paths (jazelly) #551710f1d13e359] - lib: ensure FORCE_COLOR forces color output in non-TTY environments (Pietro Marchini) #55404dcbc5fbe65] - (SEMVER-MINOR)lib: add UV_UDP_REUSEPORT for udp (theanarkh) #55403714f272423] - lib: remove startsWith/endsWith primordials for char checks (Gürgün Dayıoğlu) #554074e5c90bb41] - lib: replacecreateDeferredPromiseutil withPromise.withResolvers(Yagiz Nizipli) #54836db18aca47a] - lib: add flag to drop connection when running in cluster mode (theanarkh) #54927dd848f2d1e] - lib: test_runner#mock:timers respeced timeout_max behaviour (BadKey) #55375a9473bb8e3] - lib: remove settled dependant signals when they are GCed (Edigleysson Silva (Edy)) #5535407ad987aa1] - lib: convert transfer sequence to array in js (Jason Zhang) #55317d54d3b24c3] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #5538112d709bd27] - meta: assign CODEOWNERS for /deps/ncrypto/* (Filip Skokan) #554260130780eec] - meta: change color to blue notify review-wanted (Rafael Gonzaga) #55423335a507027] - meta: bump codecov/codecov-action from 4.5.0 to 4.6.0 (dependabot[bot]) #552225ffc721d09] - meta: bump github/codeql-action from 3.26.6 to 3.26.10 (dependabot[bot]) #55221d9fde2c45b] - meta: bump step-security/harden-runner from 2.9.1 to 2.10.1 (dependabot[bot]) #552202c960a212e] - module: include module information in require(esm) warning (Joyee Cheung) #55397a12dbf03d9] - module: simplify ts under node_modules check (Marco Ippolito) #55440ec867ac7ce] - (SEMVER-MINOR)net: add UV_TCP_REUSEPORT for tcp (theanarkh) #554089e320279a2] - Revert "path: fix bugs and inconsistencies" (Aviv Keller) #554141ce8928db3] - sqlite: cache column names in stmt.all() (Fedor Indutny) #55373cc775d314a] - src: switch fromGet/SetPrototypetoGet/SetPrototypeV2(Aviv Keller) #5545389c96ade53] - src: remove icu basedToASCIIandToUnicode(Yagiz Nizipli) #5515657dbbf8402] - src: fix winapi_strerror error string (Hüseyin Açacak) #55207a490bb8745] - src: remove uv__node_patch_is_using_io_uring (Santiago Gimeno) #551140da1632937] - src,lib: introduceutil.getSystemErrorMessage(err)(Juan José) #540756764273127] - stream: propagate AbortSignal reason (Marvin ROGER) #554734dc2791cdd] - test: add repl preview timeout test (Chengzhong Wu) #554848634e054d4] - test: make test-node-output-v8-warning more flexible (Shelley Vohr) #554016c8564b55d] - test: fix addons and node-api test assumptions (Antoine du Hamel) #5544194e863cdb7] - test: update wpt test for webmessaging/broadcastchannel (devstone) #55205c10c6715cd] - test: deflaketest-cluster-shared-handle-bind-privileged-port(Aviv Keller) #553786f7379a048] - test: fix invalidfile:URL intest-fs-path-dir(Antoine du Hamel) #55454dd5a08d022] - test: updateconsolewpt (Aviv Keller) #551929b7b4a6b25] - test: remove duplicate tests (Luigi Pinca) #55393eb2fab3da1] - test: update test_util.cc for coverage (minkyu_kim) #5529159923d137e] - test: updatecompressionwpt (Aviv Keller) #551911b63a822ac] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #5542797c6448f63] - test_runner: mark mockTimers as stable (Erick Wendel) #5539869ee56aacd] - test_runner: add support for scheduler.wait on mock timers (Erick Wendel) #55244d9f0407cf6] - test_runner: require--enable-source-mapsfor sourcemap coverage (Aviv Keller) #553592ac2c5a7e7] - tools: update lint-md-dependencies (Node.js GitHub Bot) #5547010f6b90f7d] - tools: update gyp-next to 0.18.3 (Node.js GitHub Bot) #5546465936a8bb6] - tools: add script to synch c-ares source lists (Richard Lau) #554451da4168486] - tools: addpolyfilledoption toprefer-primordialsrule (Antoine du Hamel) #553183b2b3a8df2] - tools: fix typos (Nathan Baulch) #55061736c085a5d] - typings: add missing type ofArrayBufferPrototypeGetByteLength(Wuli Zuo) #554397b3e38b855] - url: handle "unsafe" characters properly inpathToFileURL(Antoine du Hamel) #54545