2024-11-20, Version 23.3.0 (Current), @RafaelGSS#55921

RafaelGSS · 2024-11-19T12:42:37Z

2024-11-20, Version 23.3.0 (Current), @RafaelGSS

Notable Changes

[5767b76c30] - doc: enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
[ccb69bb8d5] - (SEMVER-MINOR)src: add cli option to preserve env vars on dr (Rafael Gonzaga) #55697
[d4e792643d] - (SEMVER-MINOR)util: add sourcemap support to getCallSites (Marco Ippolito) #55589
[00e092bb4b] - (SEMVER-MINOR)util: fix util.getCallSites plurality (Chengzhong Wu) #55626

Commits

[9862912d41] - assert: differentiate cases where cause is undefined or missing (Antoine du Hamel) #55738
[32e5bbca95] - benchmark: add test-reporters (Aviv Keller) #55757
[c2103354e6] - benchmark: add test_runner/mock-fn (Aviv Keller) #55771
[472d55e3e4] - build: implement node_use_amaro flag in GN build (Cheng) #55798
[77735674eb] - build: use glob for dependencies of out/Makefile (Richard Lau) #55789
[bba7323d51] - build: apply cpp linting and formatting to ncrypto (Aviv Keller) #55362
[e0c222525e] - crypto: allow length=0 for HKDF and PBKDF2 in SubtleCrypto.deriveBits (Filip Skokan) #55866
[cad557ec53] - deps: update simdutf to 5.6.1 (Node.js GitHub Bot) #55850
[dc8aca3692] - deps: update undici to 6.21.0 (Node.js GitHub Bot) #55851
[e0db9ede4f] - deps: update c-ares to v1.34.3 (Node.js GitHub Bot) #55803
[e147935144] - deps: update icu to 76.1 (Node.js GitHub Bot) #55551
[e0ef65b8d5] - doc: remove non-working example (Antoine du Hamel) #55856
[ec953bca09] - doc: add node:sqlite to mandatory node: prefix list (翠 / green) #55846
[1b863b96d5] - doc: add -S flag release preparation example (Antoine du Hamel) #55836
[a8311847d1] - doc: clarify UV_THREADPOOL_SIZE env var usage (Preveen P) #55832
[787e51e603] - doc: add notable-change mention to sec release (Rafael Gonzaga) #55830
[e56265cc18] - doc: fix history info for URL.prototype.toJSON (Antoine du Hamel) #55818
[c5afdaf5cb] - doc: correct max-semi-space-size statement (Joe Bowbeer) #55812
[65ffb2cae3] - doc: update unflag info of import.meta.resolve (skyclouds2001) #55810
[9aeb671677] - doc: run license-builder (github-actions[bot]) #55813
[df5ea1a5b3] - doc: clarify triager role (Gireesh Punathil) #55775
[aa12de0f03] - doc: sort --report-exclude alphabetically (Rafael Gonzaga) #55788
[8576ca9897] - doc: clarify removal of experimental API does not require a deprecation (Antoine du Hamel) #55746
[5767b76c30] - doc: enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
[1f2fcf1dc8] - doc: add history entries for JSON modules stabilization (Antoine du Hamel) #55855
[83ba688d8f] - esm: fix import.meta.resolve crash (Marco Ippolito) #55777
[bdb6d12e7a] - events: add hasEventListener util for validate (Sunghoon) #55230
[d41cb49516] - fs: prevent unwanted dependencyOwners removal (Carlos Espa) #55565
[db0d648d8f] - fs: fix bufferSize option for opendir recursive (Ethan Arrowood) #55744
[693fda0802] - lib: remove unused file fetch_module (Michaël Zasso) #55880
[156873303a] - lib: prefer symbol to number in webidl type function (Antoine du Hamel) #55737
[cfe28b161a] - lib: remove unnecessary optional chaining (Gürgün Dayıoğlu) #55728
[bbb8f5914d] - lib: use Promise.withResolvers() in timers (Yagiz Nizipli) #55720
[11e1bdd409] - module: tidy code string concat → string templates (Jacob Smith) #55820
[9c99255468] - permission: ignore internalModuleStat on module loading (Rafael Gonzaga) #55797
[5a437c446f] - report: fix network queries in getReport libuv with exclude-network (Adrien Foulon) #55602
[bcbba723de] - sqlite: add support for SQLite Session Extension (Bart Louwers) #54181
[49d55228de] - src: use env strings to create sqlite results (Michaël Zasso) #55785
[58d7a6ec10] - Revert "src: migrate String::Value to String::ValueView" (Michaël Zasso) #55828
[16786a6df8] - src: improve node:os userInfo performance (Yagiz Nizipli) #55719
[ccb69bb8d5] - (SEMVER-MINOR)src: add cli option to preserve env vars on dr (Rafael Gonzaga) #55697
[770670c52c] - test: fix permission fixtures lint (Rafael Gonzaga) #55819
[84c47478d0] - test: improve test coverage for child process message sending (Juan José) #55710
[e1f54e2527] - test: ensure that test priority is not higher than current priority (Livia Medeiros) #55739
[e1b42e7637] - test: add buffer to fs_permission tests (Rafael Gonzaga) #55734
[d1ad43e9ae] - test: improve test coverage for ServerResponse (Juan José) #55711
[034505e037] - test_runner: error on mocking an already mocked date (Aviv Keller) #55858
[44324aa7e9] - tools: bump @eslint/plugin-kit from 0.2.0 to 0.2.3 in /tools/eslint (dependabot[bot]) #55875
[3cfacd3fbb] - tools: fix exclude labels for commit-queue (Richard Lau) #55809
[8111a7655d] - tools: make commit-queue check blocked label (Marco Ippolito) #55781
[419ea068fb] - tools: remove non-existent file from eslint config (Aviv Keller) #55772
[7814669377] - tools: fix c-ares updater script for Node.js 18 (Richard Lau) #55717
[3a9733cc4f] - util: do not mark experimental feature as deprecated (Antoine du Hamel) #55740
[d4e792643d] - (SEMVER-MINOR)util: add sourcemap support to getCallSites (Marco Ippolito) #55589
[00e092bb4b] - (SEMVER-MINOR)util: fix util.getCallSites plurality (Chengzhong Wu) #55626

PR-URL: #55855 Refs: #55333 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

`util.getCallSite` returns an array of call site objects. Rename the function to reflect that it returns a given count of frames captured as an array of call site object. Renames the first parameter `frames` to be `frameCount` to indicate that it specifies the count of returned call sites. PR-URL: #55626 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

PR-URL: #55589Fixes: #55109 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

GitHub Actions is by default running the tools updater workflow with Node.js 18. Avoid use of `import.meta.dirname`, which wasn't backported to Node.js 18. PR-URL: #55717 Refs: #55445 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: #55720 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>

PR-URL: #55551 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: #55728 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #55711 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>

Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #55732 Refs: nodejs/Release#1054 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: #55734 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: #55737 Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jason Zhang <[email protected]>

PR-URL: #55738 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: #55739 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: #55746 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

The bufferSize option was not respected in recursive mode. This PR implements a naive solution to fix this issue until a better implementation can be designed. Fixes: #48820 PR-URL: #55744 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: #55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #55710 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: #55697 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: #55719 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: #55788 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>

PR-URL: #55772 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>

PR-URL: #55781 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

The `gh` cli doesn't recognise `--no-label`. Instead exclude labels via the `--search` flag. Refs: #55781 (comment) Refs: cli/cli#4142 PR-URL: #55809 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>

PR-URL: #55362 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed. Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`. PR-URL: #55789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

highlight additional points around triager role Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #55775 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: #55813 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

PR-URL: #55777Fixes: #55518 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check. Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where `a` attempt to load b, it will fails as it reads $pwd and no permission has been given to this path. PR-URL: #55797 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>

Notable changes: doc: * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) #55697 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) #55589 * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) #55626 PR-URL: #55921

nodejs-github-bot · 2024-11-19T13:52:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63630/
CITGM: https://ci.nodejs.org/job/citgm-smoker/3513/
CITGM (v23.x): https://ci.nodejs.org/job/citgm-smoker/3514/
📦 https://ci-release.nodejs.org/job/iojs+release/10617/

codecov · 2024-11-19T15:06:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (a83fbdb) to head (72f82ad).
Report is 58 commits behind head on v23.x.

Additional details and impacted files

@@ Coverage Diff @@## v23.x #55921 +/- ## ========================================== - Coverage 88.41% 88.01% -0.41%  ========================================== Files 654 653 -1 Lines 187665 187709 +44 Branches 36125 35884 -241 ========================================== - Hits 165930 165217 -713 - Misses 14965 15675 +710 - Partials 6770 6817 +47

see 114 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

aduh95 · 2024-11-20T12:47:49Z

doc/changelogs/CHANGELOG_V23.md

+### Notable Changes
+
+*\[[`5767b76c30`](https://github.com/nodejs/node/commit/5767b76c30)] - **doc**: enforce strict policy to semver-major releases (Rafael Gonzaga) [#55732](https://github.com/nodejs/node/pull/55732)
+*\[[`ccb69bb8d5`](https://github.com/nodejs/node/commit/ccb69bb8d5)] - **(SEMVER-MINOR)****src**: add cli option to preserve env vars on dr (Rafael Gonzaga) [#55697](https://github.com/nodejs/node/pull/55697)


When working on the blog post, IMO it would be useful to amend this to say "diagnostic report" instead of "dr"

I agree, but I also think that we should not accept "dr" in the commit message in the first place.

I wrote it to not exceed the commit message length.

RafaelGSS · 2024-11-20T14:03:27Z

CITGM Results comparing against 3504 (v23.3.2-proposal)

FAILURE: 22 failures in 3513 not present in 3504 ┌────────────────────────┬───────────────────────────┬───────────────────────────┬──────────────────┬──────────────────┬───────────────────┬──────────────────┐ │ (index) │ 0 │ 1 │ 2 │ 3 │ 4 │ 5 │ ├────────────────────────┼───────────────────────────┼───────────────────────────┼──────────────────┼──────────────────┼───────────────────┼──────────────────┤ │ aix72-ppc64 │ 'express-session-v1.18.1' │ 'undici-v6.21.0' │ │ │ │ │ │ fedora-last-latest-x64 │ 'undici-v6.21.0' │ │ │ │ │ │ │ win-vs2022 │ 'undici-v6.21.0' │ │ │ │ │ │ │ debian12-x64 │ 'bcrypt-v5.1.1' │ 'express-session-v1.18.1' │ 'fastify-v5.1.0' │ 'undici-v6.21.0' │ │ │ │ alpine-latest-x64 │ 'JSONStream-v1.3.5' │ 'undici-v6.21.0' │ │ │ │ │ │ rhel8-x64 │ 'undici-v6.21.0' │ │ │ │ │ │ │ ubuntu2204-64 │ 'undici-v6.21.0' │ │ │ │ │ │ │ rhel8-s390x │ 'underscore-v1.13.7' │ 'undici-v6.21.0' │ │ │ │ │ │ osx11-x64 │ │ │ │ │ │ │ │ osx11 │ 'undici-v6.21.0' │ │ │ │ │ │ │ fedora-latest-x64 │ 'JSONStream-v1.3.5' │ 'microtime-v3.1.1' │ 'mime-v4.0.4' │ 'pumpify-v2.0.1' │ 'throughv-v1.0.4' │ 'undici-v6.21.0' │ │ rhel8-ppc64le │ 'undici-v6.21.0' │ │ │ │ │ │ └────────────────────────┴───────────────────────────┴───────────────────────────┴──────────────────┴──────────────────┴───────────────────┴──────────────────┘ These modules failed in all platforms: undici-v6.21.0

undici has been failing with:

[v20] Request should fail if allowH2 is false and server advertises h1 only (52.421621ms) AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: + actual - expected + '00000001:error:0A000460:SSL routines:ssl3_read_bytes:tlsv1 alert no application protocol:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1605:SSL alert number 120\n' - 'Client network socket disconnected before secure TLS connection was established'

@nodejs/undici, could you please check? https://ci.nodejs.org/job/citgm-smoker/3513/nodes=fedora-last-latest-x64/testReport/junit/(root)/citgm/undici_v6_21_0/

marco-ippolito · 2024-11-20T14:06:46Z

Same failure on v20, you can ignore it #55879 (comment)

Notable changes: doc: * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) #55697 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) #55589 * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) #55626 PR-URL: #55921

PR-URL: #55921

Refs: nodejs/node#55921

* Blog: v23.3.0 release post Refs: nodejs/node#55921 * Update apps/site/pages/en/blog/release/v23.3.0.md Co-authored-by: Antoine du Hamel <[email protected]> Signed-off-by: Rafael Gonzaga <[email protected]> --------- Signed-off-by: Rafael Gonzaga <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]>

Notable changes: doc: * enforce strict policy to semver-major releases (Rafael Gonzaga) nodejs#55732 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) nodejs#55697 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) nodejs#55589 * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) nodejs#55626 PR-URL: nodejs#55921

* Blog: v23.3.0 release post Refs: nodejs/node#55921 * Update apps/site/pages/en/blog/release/v23.3.0.md Co-authored-by: Antoine du Hamel <[email protected]> Signed-off-by: Rafael Gonzaga <[email protected]> --------- Signed-off-by: Rafael Gonzaga <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]>

Notable changes: doc: * enforce strict policy to semver-major releases (Rafael Gonzaga) nodejs#55732 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) nodejs#55697 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) nodejs#55589 * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) nodejs#55626 PR-URL: nodejs#55921

aduh95and others added 30 commits November 16, 2024 17:42

doc: add history entries for JSON modules stabilization
1f2fcf1
PR-URL: #55855 Refs: #55333 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

util: add sourcemap support to getCallSites
d4e7926
PR-URL: #55589Fixes: #55109 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

lib: use Promise.withResolvers() in timers
bbb8f59
PR-URL: #55720 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>

deps: update icu to 76.1
e147935
PR-URL: #55551 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>

test: improve test coverage for ServerResponse
d1ad43e
Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #55711 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>

test: add buffer to fs_permission tests
e1b42e7
PR-URL: #55734 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

assert: differentiate cases where cause is undefined or missing
9862912
PR-URL: #55738 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

test: ensure that test priority is not higher than current priority
e1f54e2
PR-URL: #55739 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

util: do not mark experimental feature as deprecated
3a9733c
PR-URL: #55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

test: improve test coverage for child process message sending
84c4747
Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #55710 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

src: add cli option to preserve env vars on dr
ccb69bb
PR-URL: #55697 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>

src: improve node:os userInfo performance
16786a6
PR-URL: #55719 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>

doc: sort --report-exclude alphabetically
aa12de0
PR-URL: #55788 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>

tools: remove non-existent file from eslint config
419ea06
PR-URL: #55772 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>

build: apply cpp linting and formatting to ncrypto
bba7323
PR-URL: #55362 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

build: implement node_use_amaro flag in GN build
472d55e
PR-URL: #55798 Refs: #54136 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

doc: run license-builder
9aeb671
PR-URL: #55813 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

esm: fix import.meta.resolve crash
83ba688
PR-URL: #55777Fixes: #55518 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

RafaelGSS added release Issues and PRs related to Node.js releases. and removed dependencies Pull requests that update a dependency file. labels Nov 19, 2024

RafaelGSS mentioned this pull request Nov 19, 2024
build: add create release proposal action #55690
Merged

RafaelGSS force-pushed the v23.3.0-proposal branch from 18eb60c to 34dba0bCompare November 19, 2024 13:42

RafaelGSS force-pushed the v23.3.0-proposal branch from 34dba0b to 72f82adCompare November 19, 2024 13:43

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2024

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2024

aduh95 approved these changes Nov 20, 2024
View reviewed changes

joyeecheung mentioned this pull request Nov 20, 2024
[v22.x] backport unflagging of --experimental-require-module and related fixes/refactorings #55217
Closed

richardlau mentioned this pull request Nov 20, 2024
doc: fix Node.js 23 column in CHANGELOG.md #55935
Merged

emyl3 mentioned this pull request Nov 20, 2024
Revert "Set node version to 23.1 (#8280)" CDCgov/prime-simplereport#8301
Merged

RafaelGSS merged commit 72f82ad into v23.xNov 20, 2024
24 checks passed

RafaelGSS deleted the v23.3.0-proposal branch November 20, 2024 22:54

RafaelGSS added a commit that referenced this pull request Nov 20, 2024
Working on v23.3.1
176b16a
PR-URL: #55921

RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Nov 20, 2024
Blog: v23.3.0 release post
c09a033
Refs: nodejs/node#55921

RafaelGSS mentioned this pull request Nov 20, 2024
Blog: v23.3.0 release post nodejs/nodejs.org#7268
Merged

richardlau mentioned this pull request Nov 21, 2024
src: add cli option to exclude env vars on dr #55697
Merged

richardlau mentioned this pull request Nov 27, 2024
doc: add added tag and fix typo sqlite.md #56012
Merged

This comment was marked as off-topic.
Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

2024-11-20, Version 23.3.0 (Current), @RafaelGSS#55921

2024-11-20, Version 23.3.0 (Current), @RafaelGSS #55921

Uh oh!

RafaelGSS commented Nov 19, 2024

Uh oh!

nodejs-github-bot commented Nov 19, 2024•
edited by RafaelGSS
Loading

Uh oh!

codecovbot commented Nov 19, 2024•
edited
Loading

Uh oh!

aduh95Nov 20, 2024

Uh oh!

targosNov 20, 2024

Uh oh!

RafaelGSSNov 20, 2024

Uh oh!

RafaelGSS commented Nov 20, 2024

Uh oh!

marco-ippolito commented Nov 20, 2024

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

2024-11-20, Version 23.3.0 (Current), @RafaelGSS#55921

2024-11-20, Version 23.3.0 (Current), @RafaelGSS #55921

Uh oh!

Conversation

RafaelGSS commented Nov 19, 2024