Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
src: fix internalModuleStat v8 fast path#58054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix internalModuleStat v8 fast path #58054
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Apr 27, 2025
Review requested:
|
b563e9e to aa493c2Comparenodejs-github-bot commented Apr 27, 2025
codecovbot commented Apr 27, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #58054 +/- ## ======================================= Coverage 90.18% 90.19% ======================================= Files 630 630 Lines 186393 186392 -1 Branches 36595 36592 -3 ======================================= + Hits 168103 168119 +16 + Misses 11090 11089 -1 + Partials 7200 7184 -16
🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
5ed1bcb into nodejs:mainUh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot commented Apr 29, 2025
Landed in 5ed1bcb |
nodejs-github-bot commented May 1, 2025
Commit Queue failed- Loading data for nodejs/node/pull/58054 ✔ Done loading data for nodejs/node/pull/58054 ----------------------------------- PR info ------------------------------------ Title src: fix internalModuleStat v8 fast path (#58054) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch anonrig:yagiz/internal-module-stat -> nodejs:main Labels lib / src, author ready, needs-ci Commits 1 - src: fix internalModuleStat v8 fast path Committers 1 - Yagiz Nizipli <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 27 Apr 2025 17:45:21 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58054#pullrequestreview-2797706038 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/58054#pullrequestreview-2797709654 ⚠ This PR was merged on Tue, 29 Apr 2025 17:53:13 GMT ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-04-27T18:10:22Z: https://ci.nodejs.org/job/node-test-pull-request/66486/ - Querying data for job/node-test-pull-request/66486/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14777283946 |
PR-URL: #58054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
PR-URL: #58054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
PR-URL: nodejs#58054 Backport-PR-URL: https://github.com/nodejs/node/pull/XXXXX Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
PR-URL: nodejs#58054 Backport-PR-URL: https://github.com/nodejs/node/pull/XXXXX Co-authored-by: René <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
PR-URL: nodejs#58054 Backport-PR-URL: nodejs#59065 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
PR-URL: nodejs#58054 Backport-PR-URL: nodejs#59065 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
PR-URL: nodejs#58054 Backport-PR-URL: nodejs#59065 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
* chore: bump node in DEPS to v22.18.0 * crypto: fix inclusion of OPENSSL_IS_BORINGSSL define nodejs/node#58845 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58960 * permission: propagate permission model flags on spawn nodejs/node#58853 * esm: syncify default path of ModuleLoader\.load nodejs/node#57419 * src: remove fast API for InternalModuleStat nodejs/node#58489 * src: simplify adding fast APIs to ExternalReferenceRegistry nodejs/node#58896 * chore: fixup patch indices * src: fix internalModuleStat v8 fast path nodejs/node#58054 * test: add tests to ensure that node.1 is kept in sync with cli.md nodejs/node#58878 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58942 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
* chore: bump node in DEPS to v22.18.0 * crypto: fix inclusion of OPENSSL_IS_BORINGSSL define nodejs/node#58845 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58960 * permission: propagate permission model flags on spawn nodejs/node#58853 * esm: syncify default path of ModuleLoader\.load nodejs/node#57419 * src: remove fast API for InternalModuleStat nodejs/node#58489 * src: simplify adding fast APIs to ExternalReferenceRegistry nodejs/node#58896 * chore: fixup patch indices * src: fix internalModuleStat v8 fast path nodejs/node#58054 * test: add tests to ensure that node.1 is kept in sync with cli.md nodejs/node#58878 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58942 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
chore: bump node to v22.18.0 (main) (#47937) * chore: bump node in DEPS to v22.18.0 * crypto: fix inclusion of OPENSSL_IS_BORINGSSL define nodejs/node#58845 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58960 * permission: propagate permission model flags on spawn nodejs/node#58853 * esm: syncify default path of ModuleLoader\.load nodejs/node#57419 * src: remove fast API for InternalModuleStat nodejs/node#58489 * src: simplify adding fast APIs to ExternalReferenceRegistry nodejs/node#58896 * chore: fixup patch indices * src: fix internalModuleStat v8 fast path nodejs/node#58054 * test: add tests to ensure that node.1 is kept in sync with cli.md nodejs/node#58878 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58942 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
* chore: bump node in DEPS to v22.18.0 * crypto: fix inclusion of OPENSSL_IS_BORINGSSL define nodejs/node#58845 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58960 * permission: propagate permission model flags on spawn nodejs/node#58853 * esm: syncify default path of ModuleLoader\.load nodejs/node#57419 * src: remove fast API for InternalModuleStat nodejs/node#58489 * src: simplify adding fast APIs to ExternalReferenceRegistry nodejs/node#58896 * chore: fixup patch indices * src: fix internalModuleStat v8 fast path nodejs/node#58054 * test: add tests to ensure that node.1 is kept in sync with cli.md nodejs/node#58878 * crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 nodejs/node#58942 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
v8 fast path was not triggering before this. I've updated the implementation and added proper test for it.
cc @nodejs/cpp-reviewers @nodejs/performance